diff options
| author | Lars-Peter Clausen <lars@metafoo.de> | 2013-05-20 19:07:30 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-05-20 11:54:55 -0700 |
| commit | 383d2fc96c1983f5cd7fca3a3b1c9b8d8ee0de66 (patch) | |
| tree | dfd04cf37ddfbe94bd3edb0887e4dd9167d9f844 | |
| parent | dbd2df859a4d992ccbceeb22c37f6a6c4aa4dc01 (diff) | |
| download | blackbird-op-linux-383d2fc96c1983f5cd7fca3a3b1c9b8d8ee0de66.tar.gz blackbird-op-linux-383d2fc96c1983f5cd7fca3a3b1c9b8d8ee0de66.zip | |
tty: nwpserial: Pass correct pointer to free_irq()
free_irq() expects the same pointer that was passed to request_irq(), otherwise
the IRQ is not freed.
The issue was found using the following coccinelle script:
<smpl>
@r1@
type T;
T devid;
@@
request_irq(..., devid)
@r2@
type r1.T;
T devid;
position p;
@@
free_irq@p(..., devid)
@@
position p != r2.p;
@@
*free_irq@p(...)
</smpl>
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/tty/serial/nwpserial.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/tty/serial/nwpserial.c b/drivers/tty/serial/nwpserial.c index 77287c54f331..549c70a2a63e 100644 --- a/drivers/tty/serial/nwpserial.c +++ b/drivers/tty/serial/nwpserial.c @@ -199,7 +199,7 @@ static void nwpserial_shutdown(struct uart_port *port) dcr_write(up->dcr_host, UART_IER, up->ier); /* free irq */ - free_irq(up->port.irq, port); + free_irq(up->port.irq, up); } static int nwpserial_verify_port(struct uart_port *port, |
