summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPavan Savoy <pavan_savoy@ti.com>2011-08-10 10:18:36 -0500
committerGreg Kroah-Hartman <gregkh@suse.de>2011-08-22 14:13:34 -0700
commit76ff0e64d42fac59fb756536342a3d3f3e4e8833 (patch)
treeb59c625ae222e7c0e43c99aea19f6cedbd7f8929
parentd0344ef670d686628f369e649c86f71c90ebe222 (diff)
downloadblackbird-op-linux-76ff0e64d42fac59fb756536342a3d3f3e4e8833.tar.gz
blackbird-op-linux-76ff0e64d42fac59fb756536342a3d3f3e4e8833.zip
drivers:misc: ti-st: free skb on firmware download
If during validation of the firmware download the data doesn't match what is expected out of the chip, this calls for a firmware download failure and a retry. Free the SKB which collects response during such scenarios. Signed-off-by: Pavan Savoy <pavan_savoy@ti.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/misc/ti-st/st_kim.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/misc/ti-st/st_kim.c b/drivers/misc/ti-st/st_kim.c
index d8ca4068a928..3a3580566dfc 100644
--- a/drivers/misc/ti-st/st_kim.c
+++ b/drivers/misc/ti-st/st_kim.c
@@ -68,6 +68,7 @@ void validate_firmware_response(struct kim_data_s *kim_gdata)
if (unlikely(skb->data[5] != 0)) {
pr_err("no proper response during fw download");
pr_err("data6 %x", skb->data[5]);
+ kfree_skb(skb);
return; /* keep waiting for the proper response */
}
/* becos of all the script being downloaded */
OpenPOWER on IntegriCloud