summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlexey Starikovskiy <alexey.y.starikovskiy@intel.com>2006-12-07 18:42:17 +0300
committerLen Brown <len.brown@intel.com>2006-12-08 02:56:07 -0500
commit50c1e1138cb94f6aca0f8555777edbcefe0324e2 (patch)
treee61e0fa46221d8744b249897aaa7c461d01cf2ad
parenta86e277259b08be0f00cfcb182922da3ffc50f04 (diff)
downloadblackbird-op-linux-50c1e1138cb94f6aca0f8555777edbcefe0324e2.tar.gz
blackbird-op-linux-50c1e1138cb94f6aca0f8555777edbcefe0324e2.zip
ACPI: ec: Drop udelay() from poll mode. Loop by reading status field instead.
Signed-off-by: Len Brown <len.brown@intel.com>
-rw-r--r--drivers/acpi/ec.c7
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index 722acafdf32e..8ef74e7b3b91 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -70,8 +70,6 @@ enum {
#define ACPI_EC_DELAY 500 /* Wait 500ms max. during EC ops */
#define ACPI_EC_UDELAY_GLK 1000 /* Wait 1ms max. to get global lock */
-#define ACPI_EC_UDELAY 100 /* Poll @ 100us increments */
-#define ACPI_EC_UDELAY_COUNT 1000 /* Wait 100ms max. during EC ops */
enum {
EC_INTR = 1, /* Output buffer full */
@@ -159,11 +157,10 @@ static int acpi_ec_check_status(struct acpi_ec *ec, u8 event)
static int acpi_ec_wait(struct acpi_ec *ec, u8 event)
{
if (acpi_ec_mode == EC_POLL) {
- int i;
- for (i = 0; i < ACPI_EC_UDELAY_COUNT; ++i) {
+ unsigned long delay = jiffies + msecs_to_jiffies(ACPI_EC_DELAY);
+ while (time_before(jiffies, delay)) {
if (acpi_ec_check_status(ec, event))
return 0;
- udelay(ACPI_EC_UDELAY);
}
} else {
if (wait_event_timeout(ec->wait,
OpenPOWER on IntegriCloud