diff options
| author | Mathias Krause <minipli@googlemail.com> | 2012-08-15 11:31:49 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-08-15 21:36:30 -0700 |
| commit | f9432c5ec8b1e9a09b9b0e5569e3c73db8de432a (patch) | |
| tree | 7f5be536c6eeacf52b2ef394af981130b83a418b | |
| parent | 9ad2de43f1aee7e7274a4e0d41465489299e344b (diff) | |
| download | blackbird-op-linux-f9432c5ec8b1e9a09b9b0e5569e3c73db8de432a.tar.gz blackbird-op-linux-f9432c5ec8b1e9a09b9b0e5569e3c73db8de432a.zip | |
Bluetooth: RFCOMM - Fix info leak in ioctl(RFCOMMGETDEVLIST)
The RFCOMM code fails to initialize the two padding bytes of struct
rfcomm_dev_list_req inserted for alignment before copying it to
userland. Additionally there are two padding bytes in each instance of
struct rfcomm_dev_info. The ioctl() that for disclosures two bytes plus
dev_num times two bytes uninitialized kernel heap memory.
Allocate the memory using kzalloc() to fix this issue.
Signed-off-by: Mathias Krause <minipli@googlemail.com>
Cc: Marcel Holtmann <marcel@holtmann.org>
Cc: Gustavo Padovan <gustavo@padovan.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/bluetooth/rfcomm/tty.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/bluetooth/rfcomm/tty.c b/net/bluetooth/rfcomm/tty.c index cb960773c002..56f182393c4c 100644 --- a/net/bluetooth/rfcomm/tty.c +++ b/net/bluetooth/rfcomm/tty.c @@ -456,7 +456,7 @@ static int rfcomm_get_dev_list(void __user *arg) size = sizeof(*dl) + dev_num * sizeof(*di); - dl = kmalloc(size, GFP_KERNEL); + dl = kzalloc(size, GFP_KERNEL); if (!dl) return -ENOMEM; |
