diff options
| author | Andre Noll <maan@systemlinux.org> | 2008-11-06 19:41:24 +1100 |
|---|---|---|
| committer | NeilBrown <neilb@suse.de> | 2008-11-06 19:41:24 +1100 |
| commit | f1cd14ae52985634d0389e934eba25b5ecf24565 (patch) | |
| tree | 131e1fedd27d63d30896233d695594508bdbd04f | |
| parent | a53a6c85756339f82ff19e001e90cfba2d6299a8 (diff) | |
| download | blackbird-op-linux-f1cd14ae52985634d0389e934eba25b5ecf24565.tar.gz blackbird-op-linux-f1cd14ae52985634d0389e934eba25b5ecf24565.zip | |
md: linear: Fix a division by zero bug for very small arrays.
We currently oops with a divide error on starting a linear software
raid array consisting of at least two very small (< 500K) devices.
The bug is caused by the calculation of the hash table size which
tries to compute sector_div(sz, base) with "base" being zero due to
the small size of the component devices of the array.
Fix this by requiring the hash spacing to be at least one which
implies that also "base" is non-zero.
This bug has existed since about 2.6.14.
Cc: stable@kernel.org
Signed-off-by: Andre Noll <maan@systemlinux.org>
Signed-off-by: NeilBrown <neilb@suse.de>
| -rw-r--r-- | drivers/md/linear.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/md/linear.c b/drivers/md/linear.c index 190147c79e79..3b90c5c924ec 100644 --- a/drivers/md/linear.c +++ b/drivers/md/linear.c @@ -148,6 +148,8 @@ static linear_conf_t *linear_conf(mddev_t *mddev, int raid_disks) min_sectors = conf->array_sectors; sector_div(min_sectors, PAGE_SIZE/sizeof(struct dev_info *)); + if (min_sectors == 0) + min_sectors = 1; /* min_sectors is the minimum spacing that will fit the hash * table in one PAGE. This may be much smaller than needed. |
