summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTakashi Iwai <tiwai@suse.de>2006-06-01 11:42:14 +0200
committerJaroslav Kysela <perex@suse.cz>2006-06-22 21:34:07 +0200
commitf079c25ab8a7d223875c5bac9b23b484e4a18f88 (patch)
treede5d3fbad8b2f9f7ff8b66410ab7eb7a96e63167
parent29463dfea754b8b360f638244f002c751aaad1b0 (diff)
downloadblackbird-op-linux-f079c25ab8a7d223875c5bac9b23b484e4a18f88.tar.gz
blackbird-op-linux-f079c25ab8a7d223875c5bac9b23b484e4a18f88.zip
[ALSA] hda-intel - Fix race in remove
Call iounmap after free_irq to avoid invalid accesses in the shared irq. The patch is taken from https://bugzilla.novell.com/show_bug.cgi?id=167869 Signed-off-by: Takashi Iwai <tiwai@suse.de>
-rw-r--r--sound/pci/hda/hda_intel.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 0154389bf95b..4070b5cd9b6b 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -1402,10 +1402,10 @@ static int azx_free(struct azx *chip)
msleep(1);
}
- if (chip->remap_addr)
- iounmap(chip->remap_addr);
if (chip->irq >= 0)
free_irq(chip->irq, (void*)chip);
+ if (chip->remap_addr)
+ iounmap(chip->remap_addr);
if (chip->bdl.area)
snd_dma_free_pages(&chip->bdl);
OpenPOWER on IntegriCloud