summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>2013-05-22 10:55:41 +0800
committerMark Brown <broonie@opensource.wolfsonmicro.com>2013-05-22 11:08:36 -0500
commitbac902d505220544824829affcf9c1b17b57b8ca (patch)
tree86e6305c4320deb72d1fe091351c06f1adaffb3a
parente1e5762823be84cb97f629bdfecb97af3d187406 (diff)
downloadblackbird-op-linux-bac902d505220544824829affcf9c1b17b57b8ca.tar.gz
blackbird-op-linux-bac902d505220544824829affcf9c1b17b57b8ca.zip
spi: topcliff-pch: fix error return code in pch_spi_probe()
Fix to return -ENOMEM in the platform_device_alloc() error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
-rw-r--r--drivers/spi/spi-topcliff-pch.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c
index 963e0f358507..637d728fbeb5 100644
--- a/drivers/spi/spi-topcliff-pch.c
+++ b/drivers/spi/spi-topcliff-pch.c
@@ -1667,6 +1667,7 @@ static int pch_spi_probe(struct pci_dev *pdev,
pd_dev = platform_device_alloc("pch-spi", i);
if (!pd_dev) {
dev_err(&pdev->dev, "platform_device_alloc failed\n");
+ retval = -ENOMEM;
goto err_platform_device;
}
pd_dev_save->pd_save[i] = pd_dev;
OpenPOWER on IntegriCloud