summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJiri Kosina <jkosina@suse.cz>2013-12-15 18:25:26 +0100
committerJiri Kosina <jkosina@suse.cz>2013-12-15 18:25:26 +0100
commitb2b98ea87a8d82d1100200324ace989970a92423 (patch)
treec723c73a39b7034d71ba6c20d3f4f3ed894666d7
parentd81cae806af428898f63391b5d7cd7ba0d87025d (diff)
downloadblackbird-op-linux-b2b98ea87a8d82d1100200324ace989970a92423.tar.gz
blackbird-op-linux-b2b98ea87a8d82d1100200324ace989970a92423.zip
HID: microsoft: no fallthrough in MS ergonomy 0xff05 usage
For 0xff05 usage in MS ergonomy keyboard quirk, we are falling through and returning 0 instread of properly (because we've performed new mapping) returning 1. Fix that. Reported-by: Joe Perches <joe@perches.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
-rw-r--r--drivers/hid/hid-microsoft.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/hid/hid-microsoft.c b/drivers/hid/hid-microsoft.c
index 551795b7da1d..c6ef6eed3091 100644
--- a/drivers/hid/hid-microsoft.c
+++ b/drivers/hid/hid-microsoft.c
@@ -73,6 +73,7 @@ static int ms_ergonomy_kb_quirk(struct hid_input *hi, struct hid_usage *usage,
set_bit(KEY_F16, input->keybit);
set_bit(KEY_F17, input->keybit);
set_bit(KEY_F18, input->keybit);
+ break;
default:
return 0;
}
OpenPOWER on IntegriCloud