diff options
| author | Johannes Berg <johannes.berg@intel.com> | 2013-07-04 18:00:08 +0200 |
|---|---|---|
| committer | Johannes Berg <johannes.berg@intel.com> | 2013-07-16 13:14:53 +0300 |
| commit | 961de6a5ee568881321cf97e826cc37e6f9bcf84 (patch) | |
| tree | 590126d758b7d490878301f30359c379a3a36607 | |
| parent | f2532b04b2ecde7c71ff30d0b26bd6d6166c4bf6 (diff) | |
| download | blackbird-op-linux-961de6a5ee568881321cf97e826cc37e6f9bcf84.tar.gz blackbird-op-linux-961de6a5ee568881321cf97e826cc37e6f9bcf84.zip | |
iwlwifi: pcie: make unused queue warning more readable
Use the return value of WARN_ONCE() and add a message with
the queue ID that's getting used.
Reviewed-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
| -rw-r--r-- | drivers/net/wireless/iwlwifi/pcie/tx.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/net/wireless/iwlwifi/pcie/tx.c b/drivers/net/wireless/iwlwifi/pcie/tx.c index c47c92165aba..134f7a109f47 100644 --- a/drivers/net/wireless/iwlwifi/pcie/tx.c +++ b/drivers/net/wireless/iwlwifi/pcie/tx.c @@ -1619,10 +1619,9 @@ int iwl_trans_pcie_tx(struct iwl_trans *trans, struct sk_buff *skb, txq = &trans_pcie->txq[txq_id]; q = &txq->q; - if (unlikely(!test_bit(txq_id, trans_pcie->queue_used))) { - WARN_ON_ONCE(1); + if (WARN_ONCE(!test_bit(txq_id, trans_pcie->queue_used), + "TX on unused queue %d\n", txq_id)) return -EINVAL; - } spin_lock(&txq->lock); |
