diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2013-10-18 12:06:56 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2013-10-18 13:56:07 -0400 |
| commit | 768877537de6b9f7c043b73f82baab4f09ee9799 (patch) | |
| tree | 3928a6454b32cbaf5389de8a66007356ad9142a1 | |
| parent | 77dfca7e45518ea87a4e90f9142b87687f55f708 (diff) | |
| download | blackbird-op-linux-768877537de6b9f7c043b73f82baab4f09ee9799.tar.gz blackbird-op-linux-768877537de6b9f7c043b73f82baab4f09ee9799.zip | |
ax25: cleanup a range test
The current test works fine in practice. The "amount" variable is
actually used as a boolean so negative values or any non-zero values
count as "true". However since we don't allow numbers greater than one,
let's not allow negative numbers either.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/ax25/af_ax25.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c index 4b4d2b779ec1..a00123ebb0ae 100644 --- a/net/ax25/af_ax25.c +++ b/net/ax25/af_ax25.c @@ -1735,7 +1735,7 @@ static int ax25_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg) res = -EFAULT; break; } - if (amount > AX25_NOUID_BLOCK) { + if (amount < 0 || amount > AX25_NOUID_BLOCK) { res = -EINVAL; break; } |
