summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorH Hartley Sweeten <hartleys@visionengravers.com>2012-06-29 11:00:40 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-07-06 15:46:08 -0700
commit6daf1e0547ab6b9797a45ea9f45a035a5abb7821 (patch)
tree8fa2fbe1eec55a8ab5f857cf594cdcf0973fff5d
parentcba9d4aa4e55547894d4625bc3f99bab2016a6c8 (diff)
downloadblackbird-op-linux-6daf1e0547ab6b9797a45ea9f45a035a5abb7821.tar.gz
blackbird-op-linux-6daf1e0547ab6b9797a45ea9f45a035a5abb7821.zip
staging: comedi: das_08: remove the 8254 'logic2phys' usage
The three 8254 timers have a 1:1 relationship to the comedi channels. The 'logic2phys' usage just makes the driver more complex. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/comedi/drivers/das08.c9
1 files changed, 3 insertions, 6 deletions
diff --git a/drivers/staging/comedi/drivers/das08.c b/drivers/staging/comedi/drivers/das08.c
index c0c93ea36b51..2ad66f270b47 100644
--- a/drivers/staging/comedi/drivers/das08.c
+++ b/drivers/staging/comedi/drivers/das08.c
@@ -448,7 +448,7 @@ static int das08_counter_read(struct comedi_device *dev,
{
struct das08_private_struct *devpriv = dev->private;
struct i8254_struct *st = &devpriv->i8254;
- int chan = st->logic2phys[insn->chanspec];
+ int chan = insn->chanspec;
data[0] = i8254_read(st->iobase, 0, chan);
return 1;
@@ -460,7 +460,7 @@ static int das08_counter_write(struct comedi_device *dev,
{
struct das08_private_struct *devpriv = dev->private;
struct i8254_struct *st = &devpriv->i8254;
- int chan = st->logic2phys[insn->chanspec];
+ int chan = insn->chanspec;
i8254_write(st->iobase, 0, chan, data[0]);
return 1;
@@ -472,7 +472,7 @@ static int das08_counter_config(struct comedi_device *dev,
{
struct das08_private_struct *devpriv = dev->private;
struct i8254_struct *st = &devpriv->i8254;
- int chan = st->logic2phys[insn->chanspec];
+ int chan = insn->chanspec;
if (insn->n != 2)
return -EINVAL;
@@ -848,9 +848,6 @@ int das08_common_attach(struct comedi_device *dev, unsigned long iobase)
s->insn_config = das08_counter_config;
/* Set-up the 8254 structure */
devpriv->i8254.channels = 3;
- devpriv->i8254.logic2phys[0] = 0;
- devpriv->i8254.logic2phys[1] = 1;
- devpriv->i8254.logic2phys[2] = 2;
devpriv->i8254.iobase = iobase + thisboard->i8254_offset;
i8254_initialize(&devpriv->i8254);
} else {
OpenPOWER on IntegriCloud