diff options
| author | Alexey Khoroshilov <khoroshilov@ispras.ru> | 2013-09-18 00:57:59 +0400 |
|---|---|---|
| committer | John W. Linville <linville@tuxdriver.com> | 2013-09-26 14:02:29 -0400 |
| commit | e78641c19de7a3b77b5d840aff239c6648983099 (patch) | |
| tree | ac06b89052d53014b0d6768641f9f4cd5904fa89 | |
| parent | 20e6e55aaaa6745fbc815845e2e5e20dc35d62e5 (diff) | |
| download | blackbird-op-linux-e78641c19de7a3b77b5d840aff239c6648983099.tar.gz blackbird-op-linux-e78641c19de7a3b77b5d840aff239c6648983099.zip | |
p54usb: fix leak at failure path in p54u_load_firmware()
If request_firmware_nowait() fails in p54u_load_firmware(),
p54u_load_firmware_cb is not called and no one decrements usb_dev refcnt.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
| -rw-r--r-- | drivers/net/wireless/p54/p54usb.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/wireless/p54/p54usb.c b/drivers/net/wireless/p54/p54usb.c index b9deef66cf4b..7fa81d13b4e5 100644 --- a/drivers/net/wireless/p54/p54usb.c +++ b/drivers/net/wireless/p54/p54usb.c @@ -979,6 +979,7 @@ static int p54u_load_firmware(struct ieee80211_hw *dev, if (err) { dev_err(&priv->udev->dev, "(p54usb) cannot load firmware %s " "(%d)!\n", p54u_fwlist[i].fw, err); + usb_put_dev(udev); } return err; |
