diff options
| author | Jonathan Brassow <jbrassow@redhat.com> | 2012-10-11 13:40:36 +1100 |
|---|---|---|
| committer | NeilBrown <neilb@suse.de> | 2012-10-11 13:40:36 +1100 |
| commit | 7386199c471f70526bbcc629f072a5a8effe218f (patch) | |
| tree | f9a9db7769a86450ccdda52fa64c2ee7f74b709e | |
| parent | 4ec1e369af83f7ecdfbd48a905e44fc9910115ba (diff) | |
| download | blackbird-op-linux-7386199c471f70526bbcc629f072a5a8effe218f.tar.gz blackbird-op-linux-7386199c471f70526bbcc629f072a5a8effe218f.zip | |
DM RAID: Fix comparison of index and quantity for "rebuild" parameter
DM RAID: Fix comparison of index and quantity for "rebuild" parameter
The "rebuild" parameter takes an index argument that starts counting from
zero. The conditional used to validate the index was using '>' rather than
'>=', leaving the door open for an index value that would be 1 too large.
Reported-by: Neil Brown <neilb@suse.de>
Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>
Signed-off-by: NeilBrown <neilb@suse.de>
| -rw-r--r-- | drivers/md/dm-raid.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index 4e79ebaab3c1..89a06a361332 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -539,7 +539,7 @@ static int parse_raid_params(struct raid_set *rs, char **argv, /* Parameters that take a numeric value are checked here */ if (!strcasecmp(key, "rebuild")) { - if (value > rs->md.raid_disks) { + if (value >= rs->md.raid_disks) { rs->ti->error = "Invalid rebuild index given"; return -EINVAL; } |
