diff options
| author | Cody P Schafer <cody@linux.vnet.ibm.com> | 2012-08-10 15:22:47 -0700 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2012-08-13 14:10:10 -0300 |
| commit | 72f86204419e1b83f18b9bc2c97141a52dc534d2 (patch) | |
| tree | 89ee19fa8f93de9c0fd93a92b3773bb95398720d | |
| parent | 261ee821c256dffa02e5608c7df51744a03992a2 (diff) | |
| download | blackbird-op-linux-72f86204419e1b83f18b9bc2c97141a52dc534d2.tar.gz blackbird-op-linux-72f86204419e1b83f18b9bc2c97141a52dc534d2.zip | |
perf symbols: Correct comment wrt kallsyms loading
In kallsyms_parse() when calling process_symbol() (a callback argument
to kallsyms_parse()), we pass start as both start & end (ie:
start=start, end=start).
In map__process_kallsym_symbol(), the length is calculated as 'end -
start + 1', making the length 1, not 0.
Essentially, start & end define an inclusive range.
Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com>
Cc: David Hansen <dave@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Matt Hellsley <matthltc@us.ibm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Link: http://lkml.kernel.org/r/1344637382-22789-2-git-send-email-cody@linux.vnet.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
| -rw-r--r-- | tools/perf/util/symbol.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c index 42c0d943f94f..9f181a86f3b2 100644 --- a/tools/perf/util/symbol.c +++ b/tools/perf/util/symbol.c @@ -605,7 +605,7 @@ int kallsyms__parse(const char *filename, void *arg, /* * module symbols are not sorted so we add all - * symbols with zero length and rely on + * symbols, setting length to 1, and rely on * symbols__fixup_end() to fix it up. */ err = process_symbol(arg, symbol_name, |
