summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYann Dirson <ydirson@altern.org>2007-10-07 02:21:29 +0200
committerStefan Richter <stefanr@s5r6.in-berlin.de>2007-10-17 00:00:09 +0200
commitc1b91ce49158d607666dbef5b8d53cd77d397589 (patch)
tree9eba555701cc09c376fa0f6c5059e90e6ccc1529
parente5f84f82bdc5f8a5ce3d33aa6a2cc727fc08bda6 (diff)
downloadblackbird-op-linux-c1b91ce49158d607666dbef5b8d53cd77d397589.tar.gz
blackbird-op-linux-c1b91ce49158d607666dbef5b8d53cd77d397589.zip
firewire: in-code doc updates.
Signed-off-by: Yann Dirson <ydirson@altern.org> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> (update)
-rw-r--r--drivers/firewire/fw-topology.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/firewire/fw-topology.c b/drivers/firewire/fw-topology.c
index 45e6f9bfe99c..0fc9b000e99d 100644
--- a/drivers/firewire/fw-topology.c
+++ b/drivers/firewire/fw-topology.c
@@ -166,7 +166,7 @@ static inline struct fw_node *fw_node(struct list_head *l)
* This function builds the tree representation of the topology given
* by the self IDs from the latest bus reset. During the construction
* of the tree, the function checks that the self IDs are valid and
- * internally consistent. On succcess this funtions returns the
+ * internally consistent. On succcess this function returns the
* fw_node corresponding to the local card otherwise NULL.
*/
static struct fw_node *build_tree(struct fw_card *card,
@@ -215,6 +215,10 @@ static struct fw_node *build_tree(struct fw_card *card,
*/
for (i = 0, h = &stack; i < child_port_count; i++)
h = h->prev;
+ /*
+ * When the stack is empty, this yields an invalid value,
+ * but that pointer will never be dereferenced.
+ */
child = fw_node(h);
node = fw_node_create(q, port_count, card->color);
OpenPOWER on IntegriCloud