diff options
| author | Ingo Molnar <mingo@elte.hu> | 2009-02-06 14:57:51 +0100 |
|---|---|---|
| committer | Ingo Molnar <mingo@elte.hu> | 2009-02-06 14:57:51 +0100 |
| commit | 7d8e23df69820e6be42bcc41d441f4860e8c76f7 (patch) | |
| tree | a39d2c85a0ba741c3fd497b9cd98136fcc4633b3 | |
| parent | 4cd4c1b40d40447fb5e7ba80746c6d7ba91d7a53 (diff) | |
| download | blackbird-op-linux-7d8e23df69820e6be42bcc41d441f4860e8c76f7.tar.gz blackbird-op-linux-7d8e23df69820e6be42bcc41d441f4860e8c76f7.zip | |
timers: split process wide cpu clocks/timers, remove spurious warning
Mike Galbraith reported that the new warning in thread_group_cputimer()
triggers en masse with Amarok running.
Oleg Nesterov observed:
Can't fastpath_timer_check()->thread_group_cputimer() have the
false warning too? Suppose we had the timer, then posix_cpu_timer_del()
removes this timer, but task_cputime_zero(&sig->cputime_expires) still
not true.
Remove the spurious debug warning.
Reported-by: Mike Galbraith <efault@gmx.de>
Explained-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
| -rw-r--r-- | include/linux/sched.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/include/linux/sched.h b/include/linux/sched.h index 082d7619b3a1..79392916d6c9 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -2208,8 +2208,6 @@ void thread_group_cputimer(struct task_struct *tsk, struct task_cputime *times) struct thread_group_cputimer *cputimer = &tsk->signal->cputimer; unsigned long flags; - WARN_ON(!cputimer->running); - spin_lock_irqsave(&cputimer->lock, flags); *times = cputimer->cputime; spin_unlock_irqrestore(&cputimer->lock, flags); |
