Blackbird™ Linux sources for OpenPOWER https://git.raptorcs.com/git/blackbird-op-linux/atom?h=master 2020-01-31T10:07:43+00:00 2020-01-31T10:07:43+00:00 Nathan Chancellor natechancellor@gmail.com 2020-01-30T01:41:30+00:00 urn:sha1:e093e53f4f70b126ff63bc422e5135e934e35a1b Clang warns (trimmed for brevity): ../drivers/power/avs/qcom-cpr.c:570:13: warning: variable 'reg_mask' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] ../drivers/power/avs/qcom-cpr.c:520:13: warning: variable 'new_uV' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] Due to the fact that Clang's static analysis happens before any optimization passes are taken into account, it cannot see that both branches in the if statement must be taken because dir cannot be something other than UP or DOWN due to the check at the top of this function. Change the else if condition to else to fix this false positive. Fixes: bf6910abf548 ("power: avs: Add support for CPR (Core Power Reduction)") Link: https://github.com/ClangBuiltLinux/linux/issues/840 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Acked-by: Kevin Hilman <khilman@baylibre.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> 2020-01-31T10:07:43+00:00 Brendan Higgins brendanhiggins@google.com 2020-01-27T23:53:56+00:00 urn:sha1:db5a10c172ed0d41aa4139ef9f1abd8128568267 Currently CONFIG_QCOM_CPR=y implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error: /usr/bin/ld: drivers/power/avs/qcom-cpr.o: in function `cpr_probe': drivers/power/avs/qcom-cpr.c:1690: undefined reference to `devm_ioremap_resource' Fix the build error by adding the unspecified dependency. Signed-off-by: Brendan Higgins <brendanhiggins@google.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> 2020-01-31T10:07:43+00:00 Heiko Stuebner heiko.stuebner@theobroma-systems.com 2020-01-21T22:28:59+00:00 urn:sha1:adef0cedeaaee0a1a9495adb599806d3c0a8b31e The supply going to the emmc/flash is named vccio6, not vccio0 and while the code does this correctly already, the comments and error output do not. So just change these values to the correct ones. Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> 2020-01-31T10:07:43+00:00 Niklas Cassel nks@flawful.org 2020-01-13T20:02:58+00:00 urn:sha1:03b10951e9f6e6297d967a903c8d743b245ae3b8 In order to easier inform the user that the driver has been initialized successfully, add a printout after the driver has been initialized. At the same time, remove a dev_dbg() that is now redundant. Signed-off-by: Niklas Cassel <nks@flawful.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> 2020-01-08T22:25:22+00:00 YueHaibing yuehaibing@huawei.com 2020-01-08T01:58:49+00:00 urn:sha1:f9900c178d61661c104c1600409ced81bf3a6037 Remove duplicated include. Signed-off-by: YueHaibing <yuehaibing@huawei.com> Acked-by: Niklas Cassel <nks@flawful.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> 2020-01-07T10:57:45+00:00 Colin Ian King colin.king@canonical.com 2020-01-06T12:05:58+00:00 urn:sha1:5aa0c467519ccd862678a15885026660c271b5b0 Currently when the call cpr_read_fuse_uV returns an error the value in the uninitialized variable ret is returned. Fix this by instread returning the error value in the variable uV. Addresses-Coverity: ("Uninitialized scalar variable") Fixes: bf6910abf548 ("power: avs: Add support for CPR (Core Power Reduction)") Signed-off-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> 2019-12-29T21:11:22+00:00 Niklas Cassel nks@flawful.org 2019-12-23T14:19:34+00:00 urn:sha1:207ca274cd4c46a418ecb250d555d712e387fce8 drivers/power/avs/qcom-cpr.c:1081:15: warning: no previous prototype for ‘cpr_get_opp_hz_for_req’ Detected when running make with W=1. Signed-off-by: Niklas Cassel <nks@flawful.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> 2019-12-29T21:11:22+00:00 Niklas Cassel nks@flawful.org 2019-12-23T14:19:33+00:00 urn:sha1:9b8c249ee9edd2666661c1c76bbebc3ec663e30c drivers/power/avs/qcom-cpr.c:896:35: warning: variable ‘prev’ set but not used Detected when running make with W=1. Signed-off-by: Niklas Cassel <nks@flawful.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> 2019-12-29T21:11:22+00:00 Niklas Cassel nks@flawful.org 2019-12-23T14:19:32+00:00 urn:sha1:9e39d28fcb23bcfd6e32267866c0f805f16c9c2d drivers/power/avs/qcom-cpr.c:402:4: error: implicit declaration of function ‘regmap_multi_reg_write’ Signed-off-by: Niklas Cassel <nks@flawful.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> 2019-12-29T21:11:22+00:00 Niklas Cassel nks@flawful.org 2019-12-23T14:19:31+00:00 urn:sha1:cad12cdeea783e8b7fc4425848028d3606a4cba8 drivers/power/avs/qcom-cpr.c:1539:5-21: warning: unsigned expression compared with zero: drv->num_corners < 0 Reported-by: kbuild test robot <lkp@intel.com> Reported-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Niklas Cassel <nks@flawful.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>