blackbird-op-linux/drivers/net/can/spi, branch master

can: mcp251x: only reset hardware as required

2019-11-11T20:57:28+00:00

This prevents unwanted glitches on the outputs when changing the link state of the can interface or when resuming from suspend. Only if the device is powered off during suspend it needs to be resetted as required by the specs. Signed-off-by: Timo Schlüßler Signed-off-by: Marc Kleine-Budde

can: mcp251x: add mcp251x_write_2regs() and make use of it

2019-11-11T20:57:28+00:00

This patch introduces the function mcp251x_write_2regs() to write two registers with one SPI transfer and converts the disabling of pending interrupts in mcp251x_stop() to it. Signed-off-by: Timo Schlüßler Signed-off-by: Marc Kleine-Budde

can: mcp251x: get rid of legacy platform data

2019-11-11T20:57:28+00:00

Instead of using legacy platform data, switch to use device properties. For clock frequency we are using well established clock-frequency property. Users, two for now, are also converted here. Cc: Daniel Mack Cc: Haojian Zhuang Cc: Robert Jarzmik Cc: Russell King Signed-off-by: Andy Shevchenko Signed-off-by: Marc Kleine-Budde

can: mcp251x: mcp251x_restart_work_handler(): Fix potential force_quit race condition

2019-11-05T11:44:22+00:00

In mcp251x_restart_work_handler() the variable to stop the interrupt handler (priv->force_quit) is reset after the chip is restarted and thus a interrupt might occur. This patch fixes the potential race condition by resetting force_quit before enabling interrupts. Signed-off-by: Timo Schlüßler Signed-off-by: Marc Kleine-Budde

can: mcp251x: Call wrapper instead of regulator_disable()

2019-09-03T08:23:57+00:00

There is no need to check for regulator presence in the ->suspend() since a wrapper does it for us. Due to this we may unconditionally set AFTER_SUSPEND_POWER flag. Signed-off-by: Andy Shevchenko Signed-off-by: Marc Kleine-Budde

can: mcp251x: Make use of device property API

2019-09-03T08:23:57+00:00

Make use of device property API in this driver so that both OF based system and ACPI based system can use this driver. Signed-off-by: Andy Shevchenko Signed-off-by: Marc Kleine-Budde

can: mcp251x: Use devm_clk_get_optional() to get the input clock

2019-09-03T08:23:57+00:00

Simplify the code which fetches the input clock by using devm_clk_get_optional(). This comes with a small functional change: previously all errors were ignored when platform data is present. Now all errors are treated as errors. If no input clock is present devm_clk_get_optional() will return NULL instead of an error which matches the behavior of the old code. Signed-off-by: Andy Shevchenko Signed-off-by: Marc Kleine-Budde

can: mcp251x: remove deprecated board file setup example

2019-09-03T08:23:57+00:00

In the pre device-tree ARM aera there were board files that configured the system (instead of a device tree). A "struct spi_board_info" was used to describe the SPI bus. As new systems should be described via device trees, this patch removes the board setup example from the driver. The "struct mcp251x_platform_data" cannot be removed completely, as there are still some in-tree users of this file. Signed-off-by: Marc Kleine-Budde

can: Delete unnecessary checks before the macro call “dev_kfree_skb”

2019-08-22T23:22:03+00:00

The dev_kfree_skb() function performs also input parameter validation. Thus the test around the shown calls is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Acked-by: Sean Nyekjaer Signed-off-by: David S. Miller

can: mcp251x: remove custom DMA mapped buffer

2019-08-20T11:41:26+00:00

There is no need to duplicate what SPI core already does, i.e. mapping buffers for DMA capable transfers. This patch removes all related pices of code. Tested-by: Sean Nyekjaer Signed-off-by: Marc Kleine-Budde