blackbird-op-linux/drivers/char/ipmi/ipmi_bt_sm.c, branch master

ipmi: Convert pr_xxx() to dev_xxx() in the BT code

2018-09-18T21:15:33+00:00

Cleanups, do the replacement and change the levels to the proper ones for the function they are serving, as many were wrong. Signed-off-by: Corey Minyard

ipmi: Convert printk(KERN_ to pr_(

2018-09-18T21:15:33+00:00

Use the more common logging style. Miscellanea: o Convert old style continuation printks without KERN_CONT to pr_cont o Coalesce formats o Realign arguments o Remove unnecessary casts Signed-off-by: Joe Perches Signed-off-by: Corey Minyard

ipmi: Move BT capabilities detection to the detect call

2018-08-31T13:42:59+00:00

The capabilities detection was being done as part of the normal state machine, but it was possible for it to be running while the upper layers of the IPMI driver were initializing the device, resulting in error and failure to initialize. Move the capabilities detection to the the detect function, so it's done before anything else runs on the device. This also simplifies the state machine and removes some code, as a bonus. Signed-off-by: Corey Minyard Reported-by: Andrew Banman Tested-by: Andrew Banman Cc:

ipmi:bt: Set the timeout before doing a capabilities check

2018-05-22T18:48:30+00:00

There was one place where the timeout value for an operation was not being set, if a capabilities request was done from idle. Move the timeout value setting to before where that change might be requested. IMHO the cause here is the invisible returns in the macros. Maybe that's a job for later, though. Reported-by: Nordmark Claes Signed-off-by: Corey Minyard Cc: stable@vger.kernel.org

ipmi: Add or fix SPDX-License-Identifier in all files

2018-02-27T13:42:51+00:00

And get rid of the license text that is no longer necessary. Signed-off-by: Corey Minyard Cc: Kees Cook Cc: Alistair Popple Cc: Jeremy Kerr Cc: Joel Stanley Cc: Rocky Craig

ipmi: Make some data const that was only read

2015-09-03T20:02:27+00:00

Several data structures were only used for reading, so make them const. Signed-off-by: Corey Minyard

Char: ipmi_bt_sm, fix infinite loop

2014-04-17T19:23:06+00:00

In read_all_bytes, we do unsigned char i; ... bt->read_data[0] = BMC2HOST; bt->read_count = bt->read_data[0]; ... for (i = 1; i <= bt->read_count; i++) bt->read_data[i] = BMC2HOST; If bt->read_data[0] == bt->read_count == 255, we loop infinitely in the 'for' loop. Make 'i' an 'int' instead of 'char' to get rid of the overflow and finish the loop after 255 iterations every time. Signed-off-by: Jiri Slaby Reported-and-debugged-by: Rui Hui Dian Cc: Tomas Cech Cc: Corey Minyard Cc: Signed-off-by: Corey Minyard Signed-off-by: Linus Torvalds

ipmi: use USEC_PER_SEC instead of 1000000 for more meaningful

2014-01-25T23:31:58+00:00

Use USEC_PER_SEC instead of 1000000, that making the later bugfix more clearly. Signed-off-by: Xie XiuQi Signed-off-by: Corey Minyard Signed-off-by: Linus Torvalds

drivers/char/ipmi: memcpy, need additional 2 bytes to avoid memory overflow

2013-05-16T20:49:25+00:00

When calling memcpy, read_data and write_data need additional 2 bytes. write_data: for checking: "if (size > IPMI_MAX_MSG_LENGTH)" for operating: "memcpy(bt->write_data + 3, data + 1, size - 1)" read_data: for checking: "if (msg_len < 3 || msg_len > IPMI_MAX_MSG_LENGTH)" for operating: "memcpy(data + 2, bt->read_data + 4, msg_len - 2)" Signed-off-by: Chen Gang Signed-off-by: Corey Minyard Cc: stable@vger.kernel.org Signed-off-by: Linus Torvalds

treewide: Fix typos in various parts of the kernel, and fix some comments.

2011-12-02T13:57:31+00:00

The below patch fixes some typos in various parts of the kernel, as well as fixes some comments. Please let me know if I missed anything, and I will try to get it changed and resent. Signed-off-by: Justin P. Mattock Acked-by: Randy Dunlap Signed-off-by: Jiri Kosina