blackbird-op-linux/drivers/block/nbd.c, branch v4.5

nbd: use ->compat_ioctl()

2016-01-09T02:20:32+00:00

Signed-off-by: Al Viro

signal: turn dequeue_signal_lock() into kernel_dequeue_signal()

2015-11-07T01:50:42+00:00

1. Rename dequeue_signal_lock() to kernel_dequeue_signal(). This matches another "for kthreads only" kernel_sigaction() helper. 2. Remove the "tsk" and "mask" arguments, they are always current and current->blocked. And it is simply wrong if tsk != current. 3. We could also remove the 3rd "siginfo_t *info" arg but it looks potentially useful. However we can simplify the callers if we change kernel_dequeue_signal() to accept info => NULL. 4. Remove _irqsave, it is never called from atomic context. Signed-off-by: Oleg Nesterov Reviewed-by: Tejun Heo Cc: David Woodhouse Cc: Felipe Balbi Cc: Markus Pargmann Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

nbd: Add locking for tasks

2015-10-08T20:21:24+00:00

The timeout handling introduced in 7e2893a16d3e (nbd: Fix timeout detection) introduces a race condition which may lead to killing of tasks that are not in nbd context anymore. This was not observed or reproducable yet. This patch adds locking to critical use of task_recv and task_send to avoid killing tasks that already left the NBD thread functions. This lock is only acquired if a timeout occures or the nbd device starts/stops. Reported-by: Ben Hutchings Signed-off-by: Markus Pargmann Reviewed-by: Ben Hutchings Fixes: 7e2893a16d3e ("nbd: Fix timeout detection") Signed-off-by: Jens Axboe

nbd: flags is a u32 variable

2015-08-17T14:23:01+00:00

The flags variable is used as u32 variable. This patch changes the type to be u32. Signed-off-by: Markus Pargmann Signed-off-by: Jens Axboe

nbd: Rename functions for clearness of recv/send path

2015-08-17T14:22:59+00:00

This patch renames functions so that it is clear what the function does. Otherwise it is not directly understandable what for example 'do_it' means. Signed-off-by: Markus Pargmann Signed-off-by: Jens Axboe

nbd: Change 'disconnect' to be boolean

2015-08-17T14:22:58+00:00

Signed-off-by: Markus Pargmann Acked-by: Pavel Machek Signed-off-by: Jens Axboe

nbd: Add debugfs entries

2015-08-17T14:22:56+00:00

Add some debugfs files that help to understand the internal state of NBD. This exports the different sizes, flags, tasks and so on. Signed-off-by: Markus Pargmann Signed-off-by: Jens Axboe

nbd: Remove variable 'pid'

2015-08-17T14:22:55+00:00

This patch uses nbd->task_recv to determine the value of the previously used variable 'pid' for sysfs. Signed-off-by: Markus Pargmann Signed-off-by: Jens Axboe

nbd: Move clear queue debug message

2015-08-17T14:22:53+00:00

This message was a warning without a reason. This patch moves it into nbd_clear_que and transforms it to a debug message. Signed-off-by: Markus Pargmann Signed-off-by: Jens Axboe

nbd: Remove 'harderror' and propagate error properly

2015-08-17T14:22:52+00:00

Instead of a variable 'harderror' we can simply try to correctly propagate errors to the userspace. This patch removes the harderror variable and passes errors through error pointers and nbd_do_it back to the userspace. Signed-off-by: Markus Pargmann Acked-by: Pavel Machek Signed-off-by: Jens Axboe