diff options
| author | Daniel Schwierzeck <daniel.schwierzeck@gmail.com> | 2015-11-06 14:15:37 +0100 |
|---|---|---|
| committer | Simon Glass <sjg@chromium.org> | 2015-11-19 20:13:42 -0700 |
| commit | 3f51a772d4b7dccc2d379762a03535408b602e54 (patch) | |
| tree | 317e7c894c76b23a1c55adb5c26255972d9f50d5 /drivers/misc | |
| parent | b6ff6ce60cd294af3678606eb51fdc2fe6b752bb (diff) | |
| download | blackbird-obmc-uboot-3f51a772d4b7dccc2d379762a03535408b602e54.tar.gz blackbird-obmc-uboot-3f51a772d4b7dccc2d379762a03535408b602e54.zip | |
sandbox: cros_ec: fix uninitialized use of len
Building with gcc-5.2 raises this warning:
drivers/misc/cros_ec_sandbox.c: In function cros_ec_sandbox_packet:
drivers/misc/cros_ec_sandbox.c:483:5: warning: len may be used uninitialized in this function [-Wmaybe-uninitialized]
if (len < 0)
^
If the function process_cmd() is called with
req_hdr->command == EC_CMD_ENTERING_MODE, the value of len will be
returned uninitialized.
Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
Acked-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'drivers/misc')
| -rw-r--r-- | drivers/misc/cros_ec_sandbox.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/misc/cros_ec_sandbox.c b/drivers/misc/cros_ec_sandbox.c index 7509612fb8..98f19a68bf 100644 --- a/drivers/misc/cros_ec_sandbox.c +++ b/drivers/misc/cros_ec_sandbox.c @@ -460,6 +460,7 @@ static int process_cmd(struct ec_state *ec, len = cros_ec_keyscan(ec, resp_data); break; case EC_CMD_ENTERING_MODE: + len = 0; break; default: printf(" ** Unknown EC command %#02x\n", req_hdr->command); |
