summaryrefslogtreecommitdiffstats
path: root/common
diff options
context:
space:
mode:
authorPeng Fan <Peng.Fan@freescale.com>2015-11-24 16:54:21 +0800
committerTom Rini <trini@konsulko.com>2015-12-05 18:22:14 -0500
commitaa722529635c16c52d9d609122fecc96ec8d03e4 (patch)
treea3797aed6aa85dfcf743d8e10ef30ae701e499d5 /common
parentbc3c89b1308281edceb67051a44026545dc7b505 (diff)
downloadblackbird-obmc-uboot-aa722529635c16c52d9d609122fecc96ec8d03e4.tar.gz
blackbird-obmc-uboot-aa722529635c16c52d9d609122fecc96ec8d03e4.zip
common: cli_hush: avoid dead code
Condition "(value == NULL && ++value == NULL)" actully will always return false. Instead, use condition "(value == NULL || *(value + 1) == 0)" to detect such expression "c=". To "c=", *(value + 1) is 0, so directly return -1, but not continue. Signed-off-by: Peng Fan <Peng.Fan@freescale.com> Cc: Rabin Vincent <rabin@rab.in> Cc: Simon Glass <sjg@chromium.org> Cc: Tom Rini <trini@konsulko.com> Reviewed-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'common')
-rw-r--r--common/cli_hush.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/common/cli_hush.c b/common/cli_hush.c
index a7cac4fcb9..f075459911 100644
--- a/common/cli_hush.c
+++ b/common/cli_hush.c
@@ -2162,7 +2162,7 @@ int set_local_var(const char *s, int flg_export)
* NAME=VALUE format. So the first order of business is to
* split 's' on the '=' into 'name' and 'value' */
value = strchr(name, '=');
- if (value == NULL && ++value == NULL) {
+ if (value == NULL || *(value + 1) == 0) {
free(name);
return -1;
}
OpenPOWER on IntegriCloud