summaryrefslogtreecommitdiffstats
path: root/common
diff options
context:
space:
mode:
authorAlexey Brodkin <Alexey.Brodkin@synopsys.com>2015-12-14 18:45:34 +0300
committerTom Rini <trini@konsulko.com>2015-12-16 10:31:31 -0500
commit52bc7c7e2b31d6ba8d394f3d22b551abfa365363 (patch)
treef3fbd32b245109c86c23850fc564d16ad9d827d4 /common
parent2e680f92b888b4cb2fde2b0c77cbde22b48933f5 (diff)
downloadblackbird-obmc-uboot-52bc7c7e2b31d6ba8d394f3d22b551abfa365363.tar.gz
blackbird-obmc-uboot-52bc7c7e2b31d6ba8d394f3d22b551abfa365363.zip
eeprom: fix eeprom write procedure
This fixes commit 1a37889b0ad084a740b4f785031d7ae9955d947b: ----------------------->8-------------------- eeprom: Pull out the RW loop Unify the code for doing read/write into single function, since the code for both the read and write is almost identical. This again trims down the code duplication. ----------------------->8-------------------- where the same one routine is utilized for both EEPROM writing and reading. The only difference was supposed to be a "read" flag which in both cases was set with 1 somehow. That lead to a missing delay in case of writing which lead to write failure (in my case no data was written). Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> Acked-by: Marek Vasut <marex@denx.de> Cc: Simon Glass <sjg@chromium.org> Cc: Tom Rini <trini@konsulko.com> Cc: Heiko Schocher <hs@denx.de>
Diffstat (limited to 'common')
-rw-r--r--common/cmd_eeprom.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/common/cmd_eeprom.c b/common/cmd_eeprom.c
index 6eab1ea083..571240a99b 100644
--- a/common/cmd_eeprom.c
+++ b/common/cmd_eeprom.c
@@ -197,7 +197,7 @@ int eeprom_write(unsigned dev_addr, unsigned offset,
* We must write the address again when changing pages
* because the address counter only increments within a page.
*/
- ret = eeprom_rw(dev_addr, offset, buffer, cnt, 1);
+ ret = eeprom_rw(dev_addr, offset, buffer, cnt, 0);
eeprom_write_enable(dev_addr, 0);
return ret;
OpenPOWER on IntegriCloud