summaryrefslogtreecommitdiffstats
path: root/common/miiphyutil.c
diff options
context:
space:
mode:
authorAnatolij Gustschin <agust@denx.de>2011-04-30 02:17:44 +0000
committerWolfgang Denk <wd@denx.de>2011-04-30 23:09:25 +0200
commitd67d5d529aa3a5c3c063a24585eeaedd5e0728eb (patch)
tree13156d4c5efad4c0a27e2a3ff9f03c1358c40e9d /common/miiphyutil.c
parentaeabdeb7a33c9cff9ae0cd804521d0d691a7c341 (diff)
downloadblackbird-obmc-uboot-d67d5d529aa3a5c3c063a24585eeaedd5e0728eb.tar.gz
blackbird-obmc-uboot-d67d5d529aa3a5c3c063a24585eeaedd5e0728eb.zip
miiphy: miiphyutil.c: fix compile warning
Fix warning introduced while recent PHY Lib changes: miiphyutil.c: In function 'miiphy_read': miiphyutil.c:304: warning: comparison is always false due to limited range of data type Signed-off-by: Anatolij Gustschin <agust@denx.de> Cc: Andy Fleming <afleming@freescale.com>
Diffstat (limited to 'common/miiphyutil.c')
-rw-r--r--common/miiphyutil.c12
1 files changed, 8 insertions, 4 deletions
diff --git a/common/miiphyutil.c b/common/miiphyutil.c
index 243cae97a4..bcab74e73a 100644
--- a/common/miiphyutil.c
+++ b/common/miiphyutil.c
@@ -294,14 +294,18 @@ int miiphy_read(const char *devname, unsigned char addr, unsigned char reg,
unsigned short *value)
{
struct mii_dev *bus;
+ int ret;
bus = miiphy_get_active_dev(devname);
- if (bus)
- *value = bus->read(bus, addr, MDIO_DEVAD_NONE, reg);
- else
+ if (!bus)
return 1;
- return (*value < 0) ? 1 : 0;
+ ret = bus->read(bus, addr, MDIO_DEVAD_NONE, reg);
+ if (ret < 0)
+ return 1;
+
+ *value = (unsigned short)ret;
+ return 0;
}
/*****************************************************************************
OpenPOWER on IntegriCloud