summaryrefslogtreecommitdiffstats
path: root/board/tqc
diff options
context:
space:
mode:
authorBin Meng <bmeng.cn@gmail.com>2016-01-25 00:29:55 -0800
committerTom Rini <trini@konsulko.com>2016-01-25 10:40:00 -0500
commit4019e54dc69ef088a46ef644b9cc2deee498c148 (patch)
tree54703f6907957fd341c4babea4c5961534a12aea /board/tqc
parentb3ce90815cee3ba311c2403b9772976daf9ed41c (diff)
downloadblackbird-obmc-uboot-4019e54dc69ef088a46ef644b9cc2deee498c148.tar.gz
blackbird-obmc-uboot-4019e54dc69ef088a46ef644b9cc2deee498c148.zip
powerpc: tqm834x: Fix build warnings in initdram()
With gcc 4.9, it produces the following warnings: CC board/tqc/tqm834x/tqm834x.o board/tqc/tqm834x/tqm834x.c: In function 'initdram': board/tqc/tqm834x/tqm834x.c:325:12: warning: iteration 3u invokes undefined behavior [-Waggressive-loop-optimizations] (((base + size - 1) >> CSBNDS_EA_SHIFT) & ^ board/tqc/tqm834x/tqm834x.c:80:2: note: containing loop for(cs = 0; cs < 4; ++cs) { ^ There is an integer overflow when cs = 3. To fix it, change parameters of set_cs_bounds() to ulong. Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Diffstat (limited to 'board/tqc')
-rw-r--r--board/tqc/tqm834x/tqm834x.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/board/tqc/tqm834x/tqm834x.c b/board/tqc/tqm834x/tqm834x.c
index d891a3844c..eca218c9cf 100644
--- a/board/tqc/tqm834x/tqm834x.c
+++ b/board/tqc/tqm834x/tqm834x.c
@@ -43,7 +43,7 @@ ulong flash_get_size (ulong base, int banknum);
/* Local functions */
static int detect_num_flash_banks(void);
static long int get_ddr_bank_size(short cs, long *base);
-static void set_cs_bounds(short cs, long base, long size);
+static void set_cs_bounds(short cs, ulong base, ulong size);
static void set_cs_config(short cs, long config);
static void set_ddr_config(void);
@@ -314,7 +314,7 @@ static long int get_ddr_bank_size(short cs, long *base)
/**************************************************************************
* Sets DDR bank CS bounds.
*/
-static void set_cs_bounds(short cs, long base, long size)
+static void set_cs_bounds(short cs, ulong base, ulong size)
{
debug("Setting bounds %08lx, %08lx for cs %d\n", base, size, cs);
if(size == 0){
OpenPOWER on IntegriCloud