diff options
| author | Wolfgang Denk <wd@denx.de> | 2011-05-04 10:32:28 +0000 |
|---|---|---|
| committer | Wolfgang Denk <wd@denx.de> | 2011-05-12 19:48:42 +0200 |
| commit | f0c0b3a9e6f28a34d6da5edabba1e874fdf8e675 (patch) | |
| tree | b48adf0159f02551ab3318f469b085cfa0b26bb8 /board/micronas | |
| parent | a02a884b95c47e114a54f2751d03f139f312af2f (diff) | |
| download | blackbird-obmc-uboot-f0c0b3a9e6f28a34d6da5edabba1e874fdf8e675.tar.gz blackbird-obmc-uboot-f0c0b3a9e6f28a34d6da5edabba1e874fdf8e675.zip | |
Fix incorrect use of getenv() before relocation
A large number of boards incorrectly used getenv() in their board init
code running before relocation. In some cases this caused U-Boot to
hang when certain environment variables grew too long.
Fix the code to use getenv_r().
Signed-off-by: Wolfgang Denk <wd@denx.de>
Cc: Stefan Roese <sr@denx.de>
Cc: The LEOX team <team@leox.org>
Cc: Michael Schwingen <michael@schwingen.org>
Cc: Georg Schardt <schardt@team-ctech.de>
Cc: Werner Pfister <Pfister_Werner@intercontrol.de>
Cc: Dirk Eibach <eibach@gdsys.de>
Cc: Peter De Schrijver <p2@mind.be>
Cc: John Zhan <zhanz@sinovee.com>
Cc: Rishi Bhattacharya <rishi@ti.com>
Cc: Peter Tyser <ptyser@xes-inc.com>
Diffstat (limited to 'board/micronas')
| -rw-r--r-- | board/micronas/vct/vct.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/board/micronas/vct/vct.c b/board/micronas/vct/vct.c index 7fc3507b0e..a8eef370e0 100644 --- a/board/micronas/vct/vct.c +++ b/board/micronas/vct/vct.c @@ -80,8 +80,9 @@ phys_size_t initdram(int board_type) int checkboard(void) { + char buf[64]; + int i = getenv_f("serial#", buf, sizeof(buf)); u32 config0 = read_c0_prid(); - char *s = getenv("serial#"); if ((config0 & 0xff0000) == PRID_COMP_LEGACY && (config0 & 0xff00) == PRID_IMP_LX4280) { @@ -108,9 +109,9 @@ int checkboard(void) } printf("Board: Micronas VCT " BOARD_NAME BOARD_NAME_ADD); - if (s != NULL) { + if (i > 0) { puts(", serial# "); - puts(s); + puts(buf); } putc('\n'); |
