summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMasahiro Yamada <yamada.masahiro@socionext.com>2016-06-15 14:33:53 +0900
committerMasahiro Yamada <yamada.masahiro@socionext.com>2016-06-22 09:22:54 +0900
commit96dccd9767311f4b8e585fd9e33fcb2a09e36951 (patch)
tree09f5f75441118163f2e8917adbfa48c035bf99ae
parentf432c33f27898070718dd568feb104fc1870ca15 (diff)
downloadblackbird-obmc-uboot-96dccd9767311f4b8e585fd9e33fcb2a09e36951.tar.gz
blackbird-obmc-uboot-96dccd9767311f4b8e585fd9e33fcb2a09e36951.zip
tools: moveconfig: simplify show_failed_boards() and show more info
Since commit 1d085568b3de ("tools: moveconfig: display log atomically in more readable format"), the function color_text() is clever enough to exclude LF from escape sequences. Exploit it for removing the "for" loops from Slots.show_failed_boards(). Also, display "(the list has been saved in moveconfig.failed)" if there are failed boards. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Reviewed-by: Joe Hershberger <joe.hershberger@ni.com>
-rwxr-xr-xtools/moveconfig.py27
1 files changed, 14 insertions, 13 deletions
diff --git a/tools/moveconfig.py b/tools/moveconfig.py
index c0ac5f4e13..7a4136d205 100755
--- a/tools/moveconfig.py
+++ b/tools/moveconfig.py
@@ -860,21 +860,22 @@ class Slots:
def show_failed_boards(self):
"""Display all of the failed boards (defconfigs)."""
- failed_boards = []
+ boards = []
+ output_file = 'moveconfig.failed'
for slot in self.slots:
- failed_boards += slot.get_failed_boards()
-
- if len(failed_boards) > 0:
- msg = [ "The following boards were not processed due to error:" ]
- msg += failed_boards
- for line in msg:
- print >> sys.stderr, color_text(self.options.color,
- COLOR_LIGHT_RED, line)
-
- with open('moveconfig.failed', 'w') as f:
- for board in failed_boards:
- f.write(board + '\n')
+ boards += slot.get_failed_boards()
+
+ if boards:
+ boards = '\n'.join(boards) + '\n'
+ msg = "The following boards were not processed due to error:\n"
+ msg += boards
+ msg += "(the list has been saved in %s)\n" % output_file
+ print >> sys.stderr, color_text(self.options.color, COLOR_LIGHT_RED,
+ msg)
+
+ with open(output_file, 'w') as f:
+ f.write(boards)
class ReferenceSource:
OpenPOWER on IntegriCloud