From c4e7bcba07ccefc7f8094172def49a7e2a2cedcc Mon Sep 17 00:00:00 2001 From: Dean Sanner Date: Mon, 17 Jun 2019 07:14:35 -0500 Subject: Compile Hostboot with -Os Hostboot currently spends a significant percentage of time loading data from PNOR across a relatively slow LPC bus. This commit enables compilation of Hostboot with -Os, optimized for space to reduce the amount of data required to be transferred across the LPC bus Rough measurements show a ~30% size reduction of the hostboot image and a ~10% reduction (improvement) in boot time Change-Id: Ib73863019595a24cc7d10e924bc5c92cd64af1ed Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84436 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: William G Hoffa --- src/usr/errl/runtime/test/test_runtimeDeconfig.H | 12 ++++++------ src/usr/isteps/istep16/call_mss_scrub.C | 2 +- src/usr/isteps/tod/runtime/rt_todintf.C | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) (limited to 'src/usr') diff --git a/src/usr/errl/runtime/test/test_runtimeDeconfig.H b/src/usr/errl/runtime/test/test_runtimeDeconfig.H index a9ba1ecbd..0cf1a0a52 100644 --- a/src/usr/errl/runtime/test/test_runtimeDeconfig.H +++ b/src/usr/errl/runtime/test/test_runtimeDeconfig.H @@ -51,8 +51,8 @@ class deconfigureTargetAtRuntimeTest : public CxxTest::TestSuite // pass in a null target pointer TARGETING::Target * l_target = nullptr; - errlHndl_t l_errl = - HWAS::theDeconfigGard().deconfigureTargetAtRuntime( + errlHndl_t l_errl = nullptr; + l_errl = HWAS::theDeconfigGard().deconfigureTargetAtRuntime( l_target, HWAS::DeconfigGard::FULLY_AT_RUNTIME, l_errl); @@ -118,8 +118,8 @@ class deconfigureTargetAtRuntimeTest : public CxxTest::TestSuite l_target = l_cores.at(0); - errlHndl_t l_errl = - HWAS::theDeconfigGard().deconfigureTargetAtRuntime( + errlHndl_t l_errl = nullptr; + l_errl = HWAS::theDeconfigGard().deconfigureTargetAtRuntime( l_target, HWAS::DeconfigGard::SPEC_DECONFIG, l_errl); @@ -179,8 +179,8 @@ class deconfigureTargetAtRuntimeTest : public CxxTest::TestSuite TARGETING::Target * l_target = l_proc.at(0); - errlHndl_t l_errl = - HWAS::theDeconfigGard().deconfigureTargetAtRuntime( + errlHndl_t l_errl = nullptr; + l_errl = HWAS::theDeconfigGard().deconfigureTargetAtRuntime( l_target, HWAS::DeconfigGard::FULLY_AT_RUNTIME, l_errl); diff --git a/src/usr/isteps/istep16/call_mss_scrub.C b/src/usr/isteps/istep16/call_mss_scrub.C index 750a85c01..0d4db2acd 100644 --- a/src/usr/isteps/istep16/call_mss_scrub.C +++ b/src/usr/isteps/istep16/call_mss_scrub.C @@ -73,7 +73,7 @@ void* call_mss_scrub (void *io_pArgs) // Determine which target type runs the maintenance commands. TARGETING::MODEL masterProcModel = masterProc->getAttr(); - TARGETING::TYPE maintTrgtType; + TARGETING::TYPE maintTrgtType = TYPE_MBA; switch ( masterProcModel ) { case MODEL_CUMULUS: maintTrgtType = TYPE_MBA; break; diff --git a/src/usr/isteps/tod/runtime/rt_todintf.C b/src/usr/isteps/tod/runtime/rt_todintf.C index cc0bdb7cf..e5c537cd3 100644 --- a/src/usr/isteps/tod/runtime/rt_todintf.C +++ b/src/usr/isteps/tod/runtime/rt_todintf.C @@ -31,7 +31,7 @@ #include // g_hostInterfaces #include // firmware_request_helper #include // TOD_RT_TOPOLOGY_RESET_BACKUP, etc -#include // errlCommit +#include using namespace ERRORLOG; -- cgit v1.2.3