From a1e236a422182e81f7877de85f3cb46dff6fc0cd Mon Sep 17 00:00:00 2001 From: Mike Baiocchi Date: Fri, 18 May 2018 15:48:24 -0500 Subject: Improve FFDC for new Node Comm Device Driver This commit adds a new custom Node Comm Device Driver error log user details section and its parser code. It also adds a function to add the target and important HW registers to an error log. Change-Id: I11893af06b7a097b43106117d648e9a431c4f3ea RTC:191008 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/59079 Reviewed-by: ILYA SMIRNOV Reviewed-by: Nicholas E. Bofferding Tested-by: Jenkins Server Tested-by: FSP CI Jenkins Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Reviewed-by: William G. Hoffa --- src/usr/secureboot/node_comm/node_comm.H | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) (limited to 'src/usr/secureboot/node_comm/node_comm.H') diff --git a/src/usr/secureboot/node_comm/node_comm.H b/src/usr/secureboot/node_comm/node_comm.H index 60a6dcae7..4e8cc97a6 100644 --- a/src/usr/secureboot/node_comm/node_comm.H +++ b/src/usr/secureboot/node_comm/node_comm.H @@ -72,8 +72,8 @@ enum node_comm_registers_t : uint64_t NCDD_REG_CTRL = 0x501342E, NCDD_REG_DATA = 0x501342F, - //MailBox Registers: - NCDD_REG_LINK_MBOX_00 = 0x5013430, //(secure) + //MailBox Registers: + NCDD_REG_LINK_MBOX_00 = 0x5013430, //(secure) /* These registers are calculated by getLinkMboxReg() below NCDD_REG_LINK_MBOX_01 = 0x5013431, @@ -154,6 +154,19 @@ errlHndl_t nodeCommMapAttn(TARGETING::Target* i_pProc, uint64_t & o_linkId, uint64_t & o_mboxId); +/** + * @brief Add FFDC for the target to an error log + * + * @param[in] i_mode Specifies XBUS or ABUS mode + * @param[in] i_pProc Proc Chip Target used to collect info from + * @param[in,out] io_log Error Log to add FFDC to + * + * @return void + */ +void getNodeCommFFDC(node_comm_modes_t i_mode, + TARGETING::Target* i_pProc, + errlHndl_t &io_log); + } // end NODECOMM namespace } // end SECUREBOOT namespace -- cgit v1.2.3