From a10dc1641d321b37c0cadc49cdef1f839dca21f2 Mon Sep 17 00:00:00 2001 From: Caleb Palmer Date: Fri, 7 Dec 2018 15:18:39 -0600 Subject: Update dimmBadDqCheckParamGetBitmap to be generic Change-Id: Ia1b7ab8fa257a3bdad8ea5fbd46add150a165e73 RTC: 201603 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/69581 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: FSP CI Jenkins Tested-by: Jenkins OP HW Reviewed-by: Brian J. Stegmiller Reviewed-by: Zane C. Shelley --- src/include/usr/fapi2/dimmBadDqBitmapFuncs.H | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) (limited to 'src/include/usr/fapi2') diff --git a/src/include/usr/fapi2/dimmBadDqBitmapFuncs.H b/src/include/usr/fapi2/dimmBadDqBitmapFuncs.H index f295d452b..5d51b7153 100644 --- a/src/include/usr/fapi2/dimmBadDqBitmapFuncs.H +++ b/src/include/usr/fapi2/dimmBadDqBitmapFuncs.H @@ -41,16 +41,17 @@ extern "C" * dimmBadDqBitmapAccessHwp to get the DQ bitmap and returns the data * for the specified rank. * - * @param[in] i_fapiTrgt Reference to MCA/MBA Target + * @param[in] i_fapiTrgt Reference to MCA/MBA/MEM_PORT Target * @param[in] i_dimm MCA/MBA port DIMM number * @param[in] i_rank DIMM rank number * @param[out] o_data Reference to data where Bad DQ bitmap is copied to - * @param[in] i_port Optional port for MBA targets. Default is port 0. + * @param[in] i_port Optional port for MBA targets only. Default is port 0. * * @return ReturnCode */ fapi2::ReturnCode p9DimmGetBadDqBitmap( const fapi2::Target - & i_fapiTrgt, + + & i_fapiTrgt, const uint8_t i_dimm, const uint8_t i_rank, uint8_t (&o_data)[mss::BAD_DQ_BYTE_COUNT], @@ -66,16 +67,17 @@ fapi2::ReturnCode p9DimmGetBadDqBitmap( const fapi2::Target * dimmBadDqBitmapAccessHwp to get the DQ bitmap, fills in the data for the * specified rank and calls dimmBadDqBitmapAccessHwp to set the DQ bitmap * - * @param[in] i_fapiTrgt Reference to MCA/MBA Chiplet + * @param[in] i_fapiTrgt Reference to MCA/MBA/MEM_PORT Target * @param[in] i_dimm MCA/MBA port DIMM number * @param[in] i_rank DIMM rank number * @param[in] i_data Reference to data where Bad DQ bitmap is copied from - * @param[in] i_port Optional port for MBA targets. Default is port 0. + * @param[in] i_port Optional port for MBA targets only. Default is port 0. * * @return ReturnCode */ fapi2::ReturnCode p9DimmSetBadDqBitmap( const fapi2::Target - & i_fapiTrgt, + + & i_fapiTrgt, const uint8_t i_dimm, const uint8_t i_rank, const uint8_t (&i_data)[mss::BAD_DQ_BYTE_COUNT], -- cgit v1.2.3