From 8d28433bcc3c927ee76cdc4231099660545b1bfa Mon Sep 17 00:00:00 2001 From: Christian Geddes Date: Mon, 12 Feb 2018 14:59:05 -0600 Subject: Fix bugs in FSP->HBRT message path for SBE errors Hostboot was expecting the incorrect order of data in messages sent from the FSP -> PHYP -> HBRT where the SBE is requesting that HBRT reset the SBE. This commit corrects the order and renames the struct for the specific role its used in. Also this commit fixes the values for the MESSAGE type sent by the FSP. CQ: SW415675 Change-Id: I08f44486054e7d0113fd7606bb40ced577080d0c Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/53883 Tested-by: Jenkins Server Tested-by: FSP CI Jenkins Tested-by: Jenkins OP Build CI Reviewed-by: Roland Veloz Tested-by: Jenkins OP HW Reviewed-by: Matt Derksen Reviewed-by: ILYA SMIRNOV Reviewed-by: Daniel M. Crowell --- src/include/runtime/generic_hbrt_fsp_message.H | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'src/include/runtime') diff --git a/src/include/runtime/generic_hbrt_fsp_message.H b/src/include/runtime/generic_hbrt_fsp_message.H index 0f28b5640..102e2692b 100644 --- a/src/include/runtime/generic_hbrt_fsp_message.H +++ b/src/include/runtime/generic_hbrt_fsp_message.H @@ -65,12 +65,12 @@ struct TargetDeconfigHbrtFspData_t /** * A useful struct to access the PLID from GenericFspMboxMessage_t.data - * The PLID will be in the first 4 bytes followed by some other data. + * in the case where the FSP is requesting Hostboot to restart a SBE */ -struct HbrtFspData_t +struct SbeRetryReqData_t { + uint32_t huid; uint32_t plid; - uint32_t userData; } PACKED ; @@ -139,9 +139,9 @@ struct GenericFspMboxMessage_t MSG_TOD_TOPOLOGY_DATA = 0x0003, MSG_DECONFIG_TARGET = 0x0004, MSG_ATTR_SYNC_REQUEST = 0x000000A5, - MSG_SBE_ERROR = 0x000000E1, - MSG_SBE_RECOVERY_SUCCESS = 0x000000E2, - MSG_SBE_RECOVERY_FAILED = 0x000000E3, + MSG_SBE_ERROR = 0x000000D4, + MSG_SBE_RECOVERY_SUCCESS = 0x000000D5, + MSG_SBE_RECOVERY_FAILED = 0x000000D6, }; /** -- cgit v1.2.3