summaryrefslogtreecommitdiffstats
path: root/src/usr/isteps
Commit message (Collapse)AuthorAgeFilesLines
...
* Fix for SW432203: fails istep at istep host_runtime_setupRichard J. Knight2018-06-121-3/+7
| | | | | | | | | | | | | | | | -the value of master_node_mask was getting set to 0x80 regardless of the node which was actually master Change-Id: I9c6c32a84536597d84ddcb59461492625e88b313 CQ:SW432203 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/60045 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Prachi Gupta <pragupta@us.ibm.com> Reviewed-by: Thi N. Tran <thi@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
* Fixes to node IPC messaging to handle non-zero base addressesBrian Bakke2018-06-071-0/+1
| | | | | | | | | | | | | | | | | | | | Current code has each Node calculate each Remote Node's IPC area remote address by performing a fixed format calculation. This change has each Node calculating its IPC area Remote address and posting this value to a local SCOM register. A Node reads a Remote Node's SCOM register to acquire the Remote IPC area address. Change-Id: I25260ce180e0d07e5e81990d4c1f99e249912491 RTC:191463 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/59177 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Prachi Gupta <pragupta@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* missing memory: istep 7 and 14 changesPrachi Gupta2018-06-062-1/+171
| | | | | | | | | | | | | | | | | | | | | There are two cases where hostboot's attention is required in istep7: - If HRMOR we booted with doesn't fall in the range of proc_mem_to_use's memory, then the SBE is old. HB will do an sbe update and request re-ipl - If HB deconfigured a bunch of dimms in istep7 and ran out of memory, then we will request a reconfig loop Then, in istep14, we added another sanity check to make sure we have memory as expected to prevent unexpected failure after exiting cache contained mode. Change-Id: I018f4ce862cc79b5d7bacbe01cc28d1d2b4fc788 CQ:SW430015 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/59696 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Re-enabling test cases that were turned off during bringupElizabeth Liner2018-06-041-1/+0
| | | | | | | | | | | | Change-Id: I1129f5fadb3fd73bf426c888fadbf8e33f615194 RTC:190805 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/58947 Reviewed-by: Richard Ward <rward15@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Prachi Gupta <pragupta@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Secure Boot: Disable x-bus node communicationNick Bofferding2018-06-021-1/+5
| | | | | | | | | | | | | | | | | | XBUS node communication using the XBUS mailbox is not allowed between chips prior to SMP init when security is enabled; disable this until it can be whollistically addressed Change-Id: Ia032c635609e15629544926b7ff92537537d9325 RTC: 191008 CQ: SW431806 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/59808 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: Prachi Gupta <pragupta@us.ibm.com> Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com>
* Add support for missing memory behind master procPrachi Gupta2018-06-021-152/+70
| | | | | | | | | | | | | | | | | | | On a phyp based system, when we detect that memory is missing behind master processor, we find a proc with memory and set ATTR_PROC_MEM_TO_USE to its HRMOR. This commit adds this support in hwas common code as HWSV will call this function, update SBE mbox registers, and IPL the system. Change-Id: I88a6cb69aa10147365c556f9cf31014066bd3d08 CQ:SW430015 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/59159 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com> Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
* Add support for getting SBE Capabilites; extract SBE Version, Commit ID and TagsRoland Veloz2018-06-013-4/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Structure sbeCapabilities_t was added to the sbe_utils.H, a common file that can be shared among other files that need the sbeCapabilities_t struct. The psuCommand structure was updated, in file sbe_psudd.H, to facilitate the PSU call to get SBE Capabilities. Also structs fifoGetCapabilitiesResponse/ fifoGetCapabilitiesRequest were added to file sbe_fifodd to facilitate the FIFO call to get SBE Capabilities. Attributes SBE_COMMIT_ID, SBE_VERSION_INFO and SBE_RELEASE_TAGS were added to the target '<id>chip-processor</id>'. These attributes are the ultimate receiver of the SBE capabilities' version, commit id and release tags info. New file sbe_capabilities.C contains the call to getPsuSbeCapabilities and getFifoSbeCapabilities which ultimately perform the call to do the PSU chip operation, FIFO chip operation and update the attributes above. In step 6, host_discover_targets, and in step 8, call_proc_check_slave_sbe_seeprom_complete, is where the calls to getPsuSbeCapabilities and getFifoSbeCapabilities are made respectively. The file FipS_SBE_Interface_Specification_v1.3a.pdf (FIFO), file Host_SBE_Interface_Specification_v0.9d.pdf and looking at HW code were used to guide the coding of this. Change-Id: I32ccdeab7bf0a478298b199d42d74650a3f393f6 RTC:181139 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56317 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Martin Gloff <mgloff@us.ibm.com> Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Prachi Gupta <pragupta@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* add a call to mss_volt_dimm_count hwpPrachi Gupta2018-05-312-64/+85
| | | | | | | | | | | | Change-Id: I2512149296dbd80e6124c83e66b239ea231b1ef9 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/59476 Disable-CI: Christian R. Geddes <crgeddes@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Secure Boot: Set trusted boot enabled in HDAT considering all nodesIlya Smirnov2018-05-312-0/+108
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change implements reporting of trusted boot status to HDAT considering all nodes of the system. To avoid inter-node communication, the check is done after the HDAT TPM info is populated for all nodes. The logic goes through all TPM Info HDAT records (for each node) and checks whether the master TPM on each node is present and functional. The result is aggregated into the trusted boot enabled bit on the master node. The check is done after the separators have been extended into TPM; this allows each primary TPM more chances to fail before we say that it's functional. Trusted boot enabled bit is reported as 1 if ALL primary TPMs on ALL booting nodes are present and functional. It is reported as 0 if at least one primary is not present or not functional. Change-Id: I926532efe85b33e95e50d84b0b5e4554852f0601 RTC: 191194 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/59279 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com> Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Defer handling attentions on non-master proc until after SMP is upDan Crowell2018-05-302-9/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | The current code enables PRD/Attention Handling on the slave processors as soon as we get the SBE started (clocks running). This is a problem because most of the FIR regs are blacklisted such that we cannot write them until after the SMP is up and we are using xscom. This restriction will lead to an infinite loop in PRD if we get a recoverable attention on the slave proc. The fix is to defer all of the attention handling on the slave procs until after the SMP is up. We will move the enabled from istep 8.5 host_attnlisten_proc to the end of istep 10.1 proc_build_smp. Note that this makes 8.5 a complete NOOP. Change-Id: I1b6542efe2cd14717d7fa55d01327121027c6862 CQ: SW429438 Backport: yes Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/59268 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com> Reviewed-by: Dean Sanner <dsanner@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
* Save and restore OBUS related firmasksChristian Geddes2018-05-295-0/+16
| | | | | | | | | | | | | | | | | | During Hostboot IPL time it is impossible to see OBUS peers because they exists on different nodes and Hostboot is unaware of other nodes. Because of this we must mask off additional OBUS related firs during Hostboot IPL time. After we have reached runtime and have re-adjusted PEER targets we can restore the FIR values to what they were prior to the additional masking Hostboot does during IPL time. Change-Id: Ib9c158191c7f68f4bd7126799ba0a0aba40cee18 CQ: SW425530 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/58916 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* call mss_volt* hwps with membufs that have same VDDR_IDPrachi Gupta2018-05-251-54/+95
| | | | | | | | | | | | | | | | | | | | For dynamic VID to work, we need to send a list of membufs that have the same VDDR_ID attribute on them to mss_volt and mss_volt_vddr_addr_offset. This commit creates a map of <VDDR_ID, vector of fapi2 membuf targets> to group and convert membufs to fapi2. Change-Id: I37745246afe817ec41bfcfee5414aacbb23fce1e CQ:SW429838 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/59200 Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com> Reviewed-by: Richard J. Knight <rjknight@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Thi N. Tran <thi@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Enables DDR4 training advancedStephen Glancy2018-05-251-2/+7
| | | | | | | | | | | | | | | | | | Change-Id: I64a05ce07b8ce734b2269a4218b3c0c06490618e Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56452 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Dev-Ready: STEPHEN GLANCY <sglancy@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: Louis Stermole <stermole@us.ibm.com> Reviewed-by: ANDRE A. MARIN <aamarin@us.ibm.com> Reviewed-by: Martin Gloff <mgloff@us.ibm.com> Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56457 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Dean Sanner <dsanner@us.ibm.com>
* Establish Base Support For Sending Mailbox Messages Across XBUS/ABUSMike Baiocchi2018-05-241-1/+23
| | | | | | | | | | | | | | | | | | | | This commit establishes base support for Secure Node Communications. It creates a new device driver to operate the XBUS and ABUS Link Mailboxes and adds base support for using these device drivers to send and receive messages. It also adds a test to perform a 2-chip XBUS Link Mailbox operation. Change-Id: I19510888c0922e5bb857cffc9426399e79e113ba RTC:191008 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/58376 Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com> Reviewed-by: ILYA SMIRNOV <ismirno@us.ibm.com> Reviewed-by: Marshall J. Wilks <mjwilks@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
* Set up core checkstop escalation using HWPElizabeth Liner2018-05-2213-78/+352
| | | | | | | | | | | | | | | | This commit creates the hostboot functionality around the p9_core_checkstop_handler HWP. At various points in the IPL when we want to turn off unit checkstops for system checkstops, and then later restore them, we call this HWP. Change-Id: I6f69a9c3a88707f29e4b86e9f4e3b3bd3dfd76b7 RTC: 147565 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56430 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
* istep21: Keep the watchdog running into the host payloadWilliam A. Kennington III2018-05-191-29/+3
| | | | | | | | | | | | | | | | | | | | Skiboot has supported and enabled the IPMI watchdog for some time now. We can now assume that it is safe keep the watchdog running when transitioning to the skiboot payload as it will handle it during startup. Resolves #137 Signed-off-by: William A. Kennington III <wak@google.com> Change-Id: I2308c2b69da1f971a2356caa3cbd318342c2e89f Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/58548 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Prachi Gupta <pragupta@us.ibm.com> Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* FFDC enhancements for core activate failsDan Crowell2018-05-191-3/+17
| | | | | | | | | | | | | | Adding some more traces to the error log we grab for core activation failures. Change-Id: I30c6985060fcffcb3382b775a52e59c08d2b51b7 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/57907 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Slave SBE scratch regs must be up to date before continueMPIPL calledChristian Geddes2018-05-182-4/+55
| | | | | | | | | | | | | | | | | There was a hole in the MPIPL path where we were not updating the slave SBE scratch registers prior to rebooting them with the continueMPIPL chip op. Without this we ran the risk of not having correct information in the registers when the slave sbe restarted. Change-Id: Ib666388ef8773cd16c3f403fa83750da3e551c55 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/58842 Reviewed-by: Martin Gloff <mgloff@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Add option to masterProcChipTargetHandle() to return functional chipMike Baiocchi2018-05-181-23/+40
| | | | | | | | | | | | | | | | | | | | | This commit adds an option to the two masterProcChipTargetHandle() functions to only look for and return a functional master proc chip as necessary with the issue in Defect SW424528. The default behavior of these functions - where the functionality is not checked - remains the same. Once use of these functions has also been updated to use this new option. Change-Id: I37049d2cb9299a9404b57d85031a364bdb257c82 CQ:SW424528 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/58920 Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com> Reviewed-by: Marshall J. Wilks <mjwilks@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Secure Boot: Remove cMFSI fencing TODONick Bofferding2018-05-171-2/+1
| | | | | | | | | | | | | | | | | Removes a TODO suggesting that Hostboot should fence FSP's cMFSI access. Since a software mechanism is used to protect the Centaur, no cMFSI fencing is required. Change-Id: If2fa4257e1a5cefd7a6c57e4b6f5184e7ac5445b RTC: 187288 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/58902 Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: ILYA SMIRNOV <ismirno@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Verify frequency attributes across nodes to match with that of master nodeSwathi Madhuri Bhattiprolu2018-05-164-0/+901
| | | | | | | | | | | | | | | | | | | | | -Existing code ensures consistency of frequency data across all modules in istep6.12. -In a multi-drawer config this data needs to be consistent across all drawers. -Master drawer sends the frequency data to all the other via IPC mechanism. -This data is compared and error is returned if there is a mismatch. Change-Id: Ia1daf1f0eeb90fbafb68417b979488b040efe535 RTC:158036 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/57542 Reviewed-by: Prachi Gupta <pragupta@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Erepair HWP - Include target type DMISumit Kumar2018-05-161-2/+0
| | | | | | | | | | | | | | | | | | | - Centaur/DMI codes made fapi2 compliant - Refactored templated functions framework - Removed 'using namespace' from header files Change-Id: I690b24e5fdf9ff7413b128efb6f2fc4043bf739a Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/58065 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com> Reviewed-by: Benjamin J. Weisenbeck <bweisenb@us.ibm.com> Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/58067 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
* PRD: move MBA maint HWPs to PRD libraryZane Shelley2018-05-151-2/+0
| | | | | | | | | | | | | | | | | | The PRD library is always loaded. We want to avoid loading these HWPs in both step 14 and step 16. Adding to PRD library so they are only loaded once. Change-Id: I3b502713a19dc628f8c161b9ac9c9107b9754817 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/58855 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Benjamin J. Weisenbeck <bweisenb@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Brian J. Stegmiller <bjs@us.ibm.com> Reviewed-by: Caleb N. Palmer <cnpalmer@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com>
* Disable memory mirroring in simics temporarilySwathi Madhuri Bhattiprolu2018-05-151-1/+17
| | | | | | | | | | | | | | | | - Enable back once the SW427497 is integrated - A story 192854 is created to enable it back Change-Id: Ia24586aea45e28da4ea4be75f9dfa1a6148de2ed RTC:192853 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/58687 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Prachi Gupta <pragupta@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Add centaur dynamic VDDR code to hostbootRichard J. Knight2018-05-113-160/+204
| | | | | | | | | | | | | | | | | | | | | | -Update the makefile for istep07 and add the call to the p9c_mss_vddr_offset hwp -Update attribute mapping to separate the centaur specific values -Update the centaur target to include the attribute for the vddr offset voltage -Update createVddrMsg to use new attributes for centaur voltages Change-Id: I3be51277b7693aa91e60c8873844be785bf97c12 RTC:157672 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/58294 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Thi N. Tran <thi@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
* Get Final HDAT Size from PAYLOAD's SPIRA sectionMike Baiocchi2018-05-081-10/+43
| | | | | | | | | | | | | | | | | This commit retrieves the amount of space the PAYLOAD has reserved for the HDAT content in its SPIRA section. It then uses this size when copying the HDAT from the temporary location (where the FSP put it with DMAs-via-TCEs) to its final location. Change-Id: I430a78a1655db85f448b3f5c30e6a83f5be4b1f6 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/58261 Reviewed-by: ILYA SMIRNOV <ismirno@us.ibm.com> Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Secure Boot: Implement Centaur SCOM cacheNick Bofferding2018-05-083-1/+53
| | | | | | | | | | | | | | | | | | | This change implements a Centaur SCOM cache for sensitive SCOM registers. The cache is initialized and enabled before the first Centaur SCOM, and disabled just prior to locking down the Centaur configuration. Once the Centaur has been locked down, the real register values are compared to the cache entries, and the Centaur is deconfigured (not garded) on any mismatch in assumptions. RTC: 187288 Change-Id: I7b13bfd7eb6b427aba115d6944958bf55e171008 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/57532 Reviewed-by: ILYA SMIRNOV <ismirno@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Secure Boot: Do not disable external cMFSI fencing in "host IPL complete" istepNick Bofferding2018-05-071-31/+0
| | | | | | | | | | | | | | | | | | Removes extraneous logic in the "host IPL complete" step which used to re-enable external access to the Centaurs over the cMFSI path. The design point is never to disable this type of access in the first place, so the noted logic was no longer necessary. Change-Id: Id46094cbd6a557a06fab5381448b7d87f12fb4a7 RTC: 187288 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/55890 Reviewed-by: ILYA SMIRNOV <ismirno@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Secure Boot: Secure Centaurs in istep 14.5Nick Bofferding2018-05-072-1/+65
| | | | | | | | | | | | | | | | | If secureboot is enabled, call HWP in istep 14.5 to secure the Centaurs. The HWP will set protection bits in the Centaur that cannot be reversed without a full re-init of the chip. Change-Id: I8f72a11b3b79df4bd9dbd6869f525d8271d36887 RTC: 187288 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/55951 Reviewed-by: ILYA SMIRNOV <ismirno@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* wrap test: Use MNFG_FLAGS instead of compile time flagPrachi Gupta2018-05-0712-70/+83
| | | | | | | | | | | | Change-Id: I347075dd2424ee8b96805456b3d7d9962f428b64 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/58347 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Continuing support, in IStep 09, to facilitate the testing of SMP wrapRoland Veloz2018-05-075-255/+242
| | | | | | | | | | | | | | | Continuing the support, in IStep 09 to make the call to p9_io_obus_linktrain and p9_io_obus_post_trainadv. Change-Id: I3d070bfc6c55224b77b6342362d5d008d0f0a61b RTC:190096 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56886 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com> Disable-CI: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: Prachi Gupta <pragupta@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Added support, in IStep 09, to facilitate the testing of SMP wrapRoland Veloz2018-05-075-490/+892
| | | | | | | | | | | | | | | | | | | | Adding support, in IStep 09 to make the call to p9_io_obus_dccal and p9_io_obus_pre_trainadv. Did a lot of refactoring of code for the call to p9_io_xbus_dccal. For the code to train p9_io_xbus_dccal there seemed to be a lot of repetitve code. Also did some consildation of code for the call to p9_io_obus_dccal and p9_io_xbus_pre_trainadv. This consildated code resides in istep09HelperFuncs.H/.C. Change-Id: I625ee12066364db4654dde8fc2072a129f9ed004 RTC:190096 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56716 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Prachi Gupta <pragupta@us.ibm.com> Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Added support, in Istep 08, to facilitate the testing of SMP wrapRoland Veloz2018-05-0716-543/+953
| | | | | | | | | | | | | | | | | | Adding support, in Istep 08 to make HWP calls for many various components. In the various istep 8 call_proc_* and istep 10 call_proc*, I was able to consolidate the HWP call into a single single function. The consolidated code for these calls exists in the file nest/nestHwpHelperFuncs. Also added a function to capture errors in file isteps/istepHelperFuncs. Change-Id: I64f73d64950a52d2923f1c3fe280c55dffd1d742 RTC:190096 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56518 Reviewed-by: Prachi Gupta <pragupta@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Rediscover I2C Targets after Host I2C ResetMike Baiocchi2018-05-071-1/+203
| | | | | | | | | | | | | | | | | | | | | | | It's possible that some targets that use I2C to detect if they are present might not be present after a system re-IPLs and performs a FSI I2C Reset. Therefore, later in the IPL, after a Host I2C Reset sequence an attempt to rediscover any of these targets is made. If any new targets are found, the system will re-IPL. Currently only supporting looking for DIMMs now on OpenPower systems with securemode enabled. Change-Id: I010135231f2f74869529a3dbc3344413b6d19dc9 RTC:178973 Backport:release-op920 CQ:SW427365 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/57744 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com> Reviewed-by: ILYA SMIRNOV <ismirno@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* MPIPL: Update MDRT count for FSP based OPAL systemVasant Hegde2018-05-071-9/+7
| | | | | | | | | | | | | | | | | At present hostboot updates MDRT actual count after MPIPL for PHYP systems only. Soon we are going to support MPIPL on FSP based OPAL system as well. Lets enable MDRT count update for FSP based OPAL system as well. Change-Id: Ibc16bf9c98786a36c2c38755da507a6e001e44db Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/58166 Reviewed-by: NAGENDRA K. GURRAM <nagendra.g@in.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Secure Boot: Basic Support For Redundant TPMIlya Smirnov2018-05-021-2/+22
| | | | | | | | | | | | | | | | | | | This change implements the detection and initialization of the backup TPM in istep 10.14. The backup TPM is presence-detected and initialized; the logs of the primary TPM are extended into the secondary TPM in istep 10.14. After the initialization of the secondary TPM, all events are extended into both TPMs. A test was created to test whether the backup TPM is initialized correctly. Change-Id: I305500c9f680115e684ab153fc882b8d5364b0d4 RTC: 134912 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/57374 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* [OPAL-MPIPL][4] Skip starting OCC in istep 6.11 in MPIPL Open-powerRaja Das2018-04-231-1/+11
| | | | | | | | | | | | | | | | In open-power system, we are skipping OCC start from SRAM in the MPIPL path at istep 6.11, Since we are hitting checkstop when we reach istep 21.1, pmComplexReset. Change-Id: I648a2508dd03fb5dd8192656247e4511c570526d Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56574 Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Move VPD cache invalidation in mfgmode after we save it for HBRTDan Crowell2018-04-191-10/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Inside call_host_runtime_setup() there is a call to VPD::goldenCacheInvalidate(). This function invalidates our VPD cache in PNOR in mfg-mode in order to allow manufacturing to modify serial numbers at runtime and have those settings take effect on the next boot. This has been in place since early P8 OpenPOWER. In that same function is a call to RUNTIME::populate_hbRuntimeData(). This is where we copy the Hostboot data out into mainstore for HBRT to use later on. One of those pieces of data is the VPD cache. In January a fix went in for a different issue that moved where populate_hbRuntimeData() was run, putting it *after* we clear it in mfgmode. Obviously that isn't going to work so well... This commit moves the invalidation later in the function so that it is after we save off the cache again. Change-Id: Idb482b583ecdb7bb8abcb617bae4ae786c110fea CQ: SW424124 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/57469 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Marshall J. Wilks <mjwilks@us.ibm.com> Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com> Reviewed-by: Corey V. Swenson <cswenson@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Adding path to use alt-memory when proc0 does not have memoryElizabeth Liner2018-04-192-18/+115
| | | | | | | | | | | | | | | | | | | | When proc0 doesn't have memory, and we are on a phyp system, we don't need to swap our master proc and we can instead just swap memory. This commit adds in the functionality to look for working memory, and send both the group and chip ID down to HWSV. Change-Id: I664d5bfcd308a4ba2ee71e3e708533c6ec9a0a71 RTC:176434 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/54403 CI-Ready: Elizabeth K. Liner <eliner@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> CI-Ready: Sachin Gupta <sgupta2m@in.ibm.com> Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
* Use HRMOR-relative addresses for temporary PAYLOAD and HDAT memoryMike Baiocchi2018-04-181-6/+9
| | | | | | | | | | | | | | | | | | | | The FSP DMAs-via-TCEs the PAYLOAD and HDAT sections into HRMOR-relative memory on the master node. However, istep21's verifyAndMove() function was not using HRMOR-relative physical addresses and failed when node0 was not configured. These changes should address this and similar code using these address spaces. Change-Id: Idba95a97de9906ba6c0203f797b526eab694b8cf CQ:SW425130 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/57357 CI-Ready: Michael Baiocchi <mbaiocch@us.ibm.com> Reviewed-by: ILYA SMIRNOV <ismirno@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Multinode SBE Window SupportJaymes Wilks2018-04-131-15/+28
| | | | | | | | | | | | | | | | | | | Code for SP ATTN, COMM, and SBE FFDC areas has been extended to all chips/nodes. The COMM area base address calculation is now updated to use the lowest addressable location for the master node. Change-Id: Ib02e62958a520c60e4bcc5bd9d4c4257893adbd9 RTC:189038 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56614 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com> Reviewed-by: ILYA SMIRNOV <ismirno@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Add unmask errors back to cen_framelockLuke Mulkey2018-04-131-0/+3
| | | | | | | | | | | | | | | | Change-Id: Ia05fadcd6676f2c076bad14002d6afc26953aaf9 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56027 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com> Reviewed-by: Louis Stermole <stermole@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Dev-Ready: LUCAS W. MULKEY <lwmulkey@us.ibm.com> Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56037 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
* Cleanup the fix for "zero length dump on single node systems".Rick Ward2018-04-122-5/+6
| | | | | | | | | | | | | | | | | | | | | | | The attribute, IS_MASTER_DRAWER, was being set in the function host_sys_fab_iovalid_processing() (istep 18.9), unfortunately that function is not called on single node systems. Had to reverse the logic on the previous IS_MASTER_DRAWER attribute, and make it an IS_SLAVE_DRAWER attribute. The reason is that there is a limitation (bug?) which requires hb-only, volatile attributes to have a default value of zero. Change-Id: Ib27349f18b2738b405649723cdcb11e2ec919991 CQ:SW423016 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56883 CI-Ready: Richard Ward <rward15@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Richard J. Knight <rjknight@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Prachi Gupta <pragupta@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
* Remove logic to deconfigure PHBs in higher position within a pecPrachi Gupta2018-04-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | Current deconfig logic will deconfigure PHBs with a higher unit position under a given pec, if we were deconfiguring the PHB with a lower unit position. For example, PEC1 has PHB1 and PHB2. If we deconfigured PHB1, then we would by association deconfigure PHB2 as well. However, if we deconfigured PHB2, then we would not deconfigure PHB1. This commit removes the logic where if PHB2 is deconfigured, PHB1 is deconfigured as well. To summarize, the end result is to be able to deconfigure PHB1 or PHB2 with no effect on the other. HWPs will handle the hw limitations we have between PHBS. Change-Id: I95b31f4d051c15d896d18adf0a7f7c1b994f5928 CQ: SW417485 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56499 Reviewed-by: Martin Gloff <mgloff@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Improve error handling when slave SBE fails to bootChristian Geddes2018-04-101-0/+26
| | | | | | | | | | | | | | | | If we fail to boot the slave SBE we should mark it in the istep errlog to ensure that we fail the istep and perform a reconfig loop. Change-Id: I70e67b5b3e1e35e0ee76eb1f158435ee44a436ef Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56882 Reviewed-by: Martin Gloff <mgloff@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Always Lock Down SBE SEEPROM After SBE UpdateIlya Smirnov2018-04-091-5/+4
| | | | | | | | | | | | | | | | | Always force the SUL to be on, regardless of the status of security on the system. This will lock down the SBE SEEPROM and prevent writes to it. Do the setting of SUL after istep 10.2 after SBE is updated. Change-Id: If18986d709a44c8848ff31486bc1154759359c4c Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56822 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com> Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Revert "Verify frequency attributes across nodes"SWATHI M. BHATTIPROLU2018-04-094-843/+0
| | | | | | | | | | | | This reverts commit 571e1d84dfe50aaa674aa7e33abb75868b432d78. Change-Id: I8720246ef94be07ce0a37151b7209c8080320d59 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56933 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* sbe_retry_handler refactorChristian Geddes2018-04-062-28/+15
| | | | | | | | | | | | | | | | | | | Previously the sbe_retry_handler had logic and wording that assumed that it was being used to tell if the slave sbe booted or not. However this code has many more use cases then that. Also there was some indirect recursion that made the code hard to follow. With this refactor the code should be easier to follow and the vocabulary used should be more generic. Change-Id: If6520197b3dd561857e336ed89d9356c1f2601d6 CQ: SW416106 RTC: 167191 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/55896 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com> Tested-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Verify frequency attributes across nodesSwathi Madhuri Bhattiprolu2018-04-054-1/+844
| | | | | | | | | | | | | | | | | | | | | | | -Existing code ensures consistency of frequency data across all modules in istep6.12. -In a multi-drawer config this data needs to be consistent across all drawers. -Master drawer sends the frequency data to all the other via IPC mechanism. -This data is compared and error is returned if there is a mismatch. Change-Id: I922d32456c9d3c4e53dae528f088dbb013c3ded9 RTC:158036 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/54825 CI-Ready: SWATHI M. BHATTIPROLU <bhmadhur@in.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Richard Ward <rward15@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
* zero length dump on single node systemsRick Ward2018-04-051-5/+13
| | | | | | | | | | | | | | | Quick hack to fix dumps on single node systems. Proposed fix did not work. This change forces isCurrentMasterNode() to always return true. Change-Id: I9366617d42923e5d13c0f7ea4f624e1749ad6810 CQ:SW423016 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56769 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
OpenPOWER on IntegriCloud