diff options
| author | Andre Marin <aamarin@us.ibm.com> | 2016-01-28 11:31:06 -0600 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2016-04-01 21:23:08 -0400 |
| commit | a08c13b301d1ee48a40474261711c6dc8174b108 (patch) | |
| tree | a17cbb21e317fd1519138b46acc7ce75c535f680 | |
| parent | 185ccad7bc54774dd67ac99a6810bea8062dbfff (diff) | |
| download | blackbird-hostboot-a08c13b301d1ee48a40474261711c6dc8174b108.tar.gz blackbird-hostboot-a08c13b301d1ee48a40474261711c6dc8174b108.zip | |
Added mss_spd_ut, edited mss_utils_ut, fixed ecmd_facade & return_code
Change-Id: Id9748b670471bcd313bb3626178f58082daed338
Original-Change-Id: I43af67f8bdce058e7af322b51b34336726e3a442
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/23904
Reviewed-by: Brian Silver <bsilver@us.ibm.com>
Tested-by: Jenkins Server
Reviewed-by: Craig C. Hamilton <cchamilt@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/22766
Tested-by: FSP CI Jenkins
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
| -rw-r--r-- | src/import/chips/p9/procedures/hwp/memory/lib/utils/checker.H | 28 |
1 files changed, 15 insertions, 13 deletions
diff --git a/src/import/chips/p9/procedures/hwp/memory/lib/utils/checker.H b/src/import/chips/p9/procedures/hwp/memory/lib/utils/checker.H index ff2a493f3..07fa67d08 100644 --- a/src/import/chips/p9/procedures/hwp/memory/lib/utils/checker.H +++ b/src/import/chips/p9/procedures/hwp/memory/lib/utils/checker.H @@ -7,7 +7,7 @@ /* */ /* EKB Project */ /* */ -/* COPYRIGHT 2015 */ +/* COPYRIGHT 2015,2016 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -237,25 +237,26 @@ namespace spd /// /// @brief Checks conditional passes and implements traces & exits if it fails /// @tparam T spd_data, of any size -/// @param[in] const fapi2::Target<fapi2::TARGET_TYPE_DIMM>& i_target_dimm, +/// @param[in] const fapi2::Target<fapi2::TARGET_TYPE_DIMM>& i_target, /// bool conditional -/// size_t spd_byte_inded -/// char* err_str +/// size_t spd_byte_index +/// const char* err_str /// @return ReturnCode /// template< typename T > -inline fapi2::ReturnCode valid_value_fail(const fapi2::Target<fapi2::TARGET_TYPE_DIMM>& i_target_dimm, +inline fapi2::ReturnCode valid_value_fail(const fapi2::Target<fapi2::TARGET_TYPE_DIMM>& i_target, bool conditional, size_t spd_byte_index, T spd_data, const char* err_str) { FAPI_ASSERT(conditional, - fapi2::MSS_VALID_VALUE(). + fapi2::MSS_SPD_DECODE_INVALID_VALUE(). set_VALUE(spd_data). - set_BYTE(spd_byte_index), + set_BYTE(spd_byte_index). + set_DIMM_TARGET(i_target), "%s %s Byte %d, Data returned: %d.", - c_str(i_target_dimm), + c_str(i_target), err_str, spd_byte_index, spd_data); @@ -268,23 +269,24 @@ fapi_try_exit: /// /// @brief Checks conditional passes and implements traces if it fails /// @tparam T spd_data, of any size -/// @param[in] const fapi2::Target<fapi2::TARGET_TYPE_DIMM>& i_target_dimm, +/// @param[in] const fapi2::Target<fapi2::TARGET_TYPE_DIMM>& i_target, /// bool conditional -/// size_t spd_byte_inded -/// char* err_str +/// size_t spd_byte_index +/// const char* err_str /// @return void /// template< typename T > -inline void valid_value_warn(const fapi2::Target<fapi2::TARGET_TYPE_DIMM>& i_target_dimm, +inline void valid_value_warn(const fapi2::Target<fapi2::TARGET_TYPE_DIMM>& i_target, bool conditional, size_t spd_byte_index, T spd_data, const char* err_str) { + // Don't print warning conditional is true if(!conditional) { FAPI_IMP("%s. %s. Byte %d, Data returned: %d.", - c_str(i_target_dimm), + c_str(i_target), err_str, spd_byte_index, spd_data ); |
