blackbird-hostboot/src/usr/pnor/test, branch 07-25-2019

Automatically include config.h

2019-12-06T16:28:47+00:00

Rather than having to remember to include config.h anywhere we reference a CONFIG variable (and usually forgetting), this adds it to the default compiler flags so that it gets included in every source file we build. Change-Id: I53622ab4d46c55d942e98cae6ec03049fd5b3d08 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/87475 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Zachary Clark Reviewed-by: Roland Veloz Reviewed-by: Christian R Geddes Reviewed-by: Nicholas E Bofferding

Remove MVPD,MEMD and CENHWIMG section from Axone pnor layout

2019-07-30T20:19:58+00:00

This commit removes the MVPD, MEMD and CENHWIMG sections from the axone pnor layout as they are not being used and pnor space is limited. Along with removing the defintion in the pnor layout xml some code changes were required to no longer attempt to load the MVPD/MEMD sections. Change-Id: I20739e30ad497737c0a30b66cc36052c08c11de2 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/80295 Reviewed-by: Glenn Miles Tested-by: Jenkins Server Reviewed-by: Matt Derksen Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Daniel M Crowell

Added more error reporting to HWSV when PNOR fails, removed superfluous code

2019-05-07T13:51:08+00:00

- Replaced the terminate (terminateExecuteTI) raw calls with bl_terminate. Returning descriptive RC codes with bl_terminate call. - Module ID MOD_PNORACC_FINDTOC(=0x08) was added to hbblModuleId enums. - Return codes RC_LPC_ERR(HBBL_COMP_ID | 0x10) and RC_TOC_NOT_FOUND_ERR(HBBL_COMP_ID | 0x11) added to hbblReasonCode enums. - Freed up space in bootoloader: - Removed unnecessary calls to the method PNOR::checkForNullBuffer, because the call is always guaranteed to return with no error. - Once the calls to PNOR::checkForNullBuffer were dropped, the method PNOR::checkForNullBuffer is no longer necessary - removed it from production code. - The unit tests relied heavily on the call to PNOR::checkForNullBuffer, was not sure if the call could be removed from the unit tests, so relocated the PNOR::checkForNullBuffer method to the unit tests, out of production code. Change-Id: I1e3f8915ee4ed9b75ad74c57627ca1d2bc3a458d CQ:SW464040 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/76787 Reviewed-by: Daniel M. Crowell Tested-by: Daniel M. Crowell

Remove DJVPD and CVPD sections from axone pnor layout

2019-04-19T15:17:42+00:00

Remove unneeded Centaur VPD and DIMM JEDEC VPD sections to help reduce axone pnor memory space. Hit a simics issue where sysmvpd.data.ecc size was overwriting the first four 4-byte words of HBB, so procmvpd_p9a.dat size was corrected to 64KB. procmvpd_p9c.dat had same issue, but the overwrite was being corrected by a following CVPD write. Change-Id: I70eb12709be0ac7b73609fb080d956ee2faa39a2 RTC:207995 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/75896 Reviewed-by: Glenn Miles Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Christian R. Geddes Reviewed-by: Daniel M. Crowell

pnor: Fall back to AST mbox transport if IPMI is unavailable

2018-10-10T18:46:36+00:00

Avoid a flag-day transition by allowing for old BMC releases. Eventually support for the AST mailbox will be removed and the indirection with it. Change-Id: Ic62ee6a0f2132583cba290098a52417d32eb772d Signed-off-by: Andrew Jeffery Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/66122 Tested-by: Jenkins Server Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Daniel M. Crowell

pnor: mboxdd: Rename class to PnorMboxDD

2018-10-10T18:46:18+00:00

The rename is in preparation for introducing the fallback code, which needs to know of both the IPMI and AST mailbox implementations. Change-Id: I32c3178ac978664f0dc6797c9ba76b6a13f71b21 Signed-off-by: Andrew Jeffery Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/66121 Tested-by: Jenkins Server Tested-by: FSP CI Jenkins Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Reviewed-by: Daniel M. Crowell

pnor: ipmidd: Rename class to PnorIpmiDD

2018-10-10T18:46:03+00:00

The rename is done in preparation for the fallback code, which needs to know of both the IPMI and AST mailbox implementations of the PNOR driver. Change-Id: Iabadb5a355f63ac72330094c842fb9c8f7afe77b Signed-off-by: Andrew Jeffery Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/66120 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Daniel M. Crowell

pnor: Rename the SFC-based PnorDD class to PnorSfcDD

2018-10-10T18:45:47+00:00

Clarify which back-end implementation the driver is using. Change-Id: I26cee706a27e26e0f218da0eb5289592202a5baf Signed-off-by: Andrew Jeffery Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/66119 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Daniel M. Crowell

pnor: Introduce an IPMI-based PNOR driver implementation

2018-10-10T18:45:29+00:00

Similar to the AST MBOX implementation, the IPMI PNOR implementation negotiates the layout of the LPC FW space with the BMC, but using IPMI rather than the AST mailbox as a protocol transport. The same protocol is still used and has simply been adapted to the new interface. Note that currently the change of transport has had a 2-3x impact on boot performance. Optimisation is an ongoing effort. Change-Id: I7f838f5b5e88ac877a725386a33df58ee5e7213c Signed-off-by: Andrew Jeffery Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/65942 Tested-by: Jenkins Server Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Daniel M. Crowell

Mark Read-Only Partitions as Such

2018-04-12T20:20:04+00:00

Partitions marked with readOnly tag in the xml were treated as WRITABLE in the code. This change modifies the permissions to be READ_ONLY and adds unit tests to test the read only functionality. Change-Id: I8c1f23fd7e30edc38ff882c59716ab63a4f310e6 CQ: SW423350 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56771 CI-Ready: ILYA SMIRNOV Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Reviewed-by: Nicholas E. Bofferding Reviewed-by: Daniel M. Crowell Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/57066 Tested-by: FSP CI Jenkins