blackbird-hostboot/src/usr/ipmibase, branch 07-25-2019

Automatically include config.h

2019-12-06T16:28:47+00:00

Rather than having to remember to include config.h anywhere we reference a CONFIG variable (and usually forgetting), this adds it to the default compiler flags so that it gets included in every source file we build. Change-Id: I53622ab4d46c55d942e98cae6ec03049fd5b3d08 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/87475 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Zachary Clark Reviewed-by: Roland Veloz Reviewed-by: Christian R Geddes Reviewed-by: Nicholas E Bofferding

Increased the BMC timeout from 5 seconds to 30 seconds

2019-08-12T15:10:57+00:00

On a zaius machine, the BMC was consistently hitting a checkstop with the system shutting down with error status 0x613 following istep 13.11 - mss_draminit_training. The theory was that it was hitting a timeout issue. Increasing the timeout from 5 seconds to 30 seconds abated the situation. It does appear that it was timeout issue. Change-Id: I825f461855b2a4a70c732f0dda308b2579d60a7d CQ:SW466685 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82034 Reviewed-by: Glenn Miles Reviewed-by: Matt Derksen Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Daniel M Crowell

Add sequence id to IPMI timeout traces

2019-04-09T15:49:39+00:00

Adding the very important IPMI sequence id to the trace that we push out when we get a timeout on a IPMI message. Change-Id: Ia89332defba1fd2901a17fb3cefeeb7d69e9737a Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/75017 Tested-by: Jenkins Server Tested-by: FSP CI Jenkins Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Reviewed-by: Matt Derksen Reviewed-by: Corey V. Swenson Reviewed-by: William G. Hoffa

Modify IPMI Timeout Value

2019-04-08T18:06:17+00:00

-- Currently the Timeout value for an IPMI message is assigned when the message is placed in the queue. The timeout value is the same whether we have 0 or 100 messages in the queue which leads to the occasional IPMI timeout when the BMC is sent a lot of messages in a short period of time. -- This fix is to implement the timeout as a per message timeout. I.E. if the message being put on the queue is the 3rd message on the queue it would get a timeout of 3x the timeout value. Change-Id: Ieb328d96144f2b1fe9dc39f57191e86cf4821c2c CQ: SW461931 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/75538 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Reviewed-by: Ilya Smirnov Tested-by: FSP CI Jenkins Tested-by: Jenkins OP HW Reviewed-by: Christian R. Geddes Reviewed-by: Daniel M. Crowell

Move watchdog timer to prevent timeout

2019-02-26T19:06:29+00:00

The watchdog used to be set in istepdispatcher.C but due to various changes to PNOR that would cause a watchdog timeout. This commit moves the watchdog out of impiext code and into impibase which allows the watchdog to be setup as soon as the ipmi resource provider comes up. Then once the code reaches istepdispatcher the watchdog is adjusted as needed. Change-Id: Ia5f13800db22cd17b0feabc5257f8f6409f54376 CQ:SW453071 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/72269 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Reviewed-by: Nicholas E. Bofferding Reviewed-by: Ilya Smirnov Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Daniel M. Crowell

Reduce ipmi trace spam for pnor hiomap messages

2018-11-27T22:28:17+00:00

Increase ipmi polling frequency to every 1ms

2018-11-20T22:06:45+00:00

Changing the polling timer from 10ms to 1ms to solve a weird pnor hang we've seen. Change-Id: I796bfff7a6bce38faa56d31a935dca1aeb0a4d41 CQ: SW451298 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/68931 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Daniel M. Crowell

Enable IPMI errl after targeting is initialized

2018-11-05T17:51:47+00:00

A recent change split IPMI into base and extended. Move the enable of IPMI errl from base to extended to avoid targeting errors. Change-Id: Ia833dd8178ff407dff1fa514b32468c5fc70e945 CQ:SW450286 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/68265 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: ANDREW R. JEFFERY Reviewed-by: Michael Baiocchi Reviewed-by: Daniel M. Crowell

ipmi: Increase polling rate to decrease boot time

2018-10-17T17:38:04+00:00

The recent introduction of the IPMI-based HIOMAP transport for the PNOR means the boot process is now heavily constrained by the speed of IPMI transfers. As an interim change to introducing interrupt-driven BT support, decrease the period of the IPMI poller to increase boot speed by a factor of about 1.7x when using the IPMI HIOMAP transport. This also slightly increases the speed of a MBOX HIOMAP boot, but the point here is that there's not a detrimental effect in this configuration. Change-Id: I853ab013e33715101383c2c80c2d1b67c1c79265 Signed-off-by: Andrew Jeffery Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/67589 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Reviewed-by: Daniel M. Crowell

pnor: Introduce an IPMI-based PNOR driver implementation

2018-10-10T18:45:29+00:00

Similar to the AST MBOX implementation, the IPMI PNOR implementation negotiates the layout of the LPC FW space with the BMC, but using IPMI rather than the AST mailbox as a protocol transport. The same protocol is still used and has simply been adapted to the new interface. Note that currently the change of transport has had a 2-3x impact on boot performance. Optimisation is an ongoing effort. Change-Id: I7f838f5b5e88ac877a725386a33df58ee5e7213c Signed-off-by: Andrew Jeffery Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/65942 Tested-by: Jenkins Server Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Daniel M. Crowell