blackbird-hostboot/src/usr/errl, branch 07-25-2019

Fix for missing HBRT error log after error injected

2020-01-15T14:42:51+00:00

An HBRT error log larger than 4K sent to the host will be truncated to 4K before it reaches HWSV, where a size mismatch prevents processing of the log. To avoid this, truncate the HBRT log to 4K before sending across interface to host. Change-Id: Ic2c354da99c0a4ccec00ce58cf6ef34bc02e7996 CQ:SW480758 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/88724 Reviewed-by: Matt Derksen Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Roland Veloz Reviewed-by: Daniel M Crowell

Automatically include config.h

2019-12-06T16:28:47+00:00

Rather than having to remember to include config.h anywhere we reference a CONFIG variable (and usually forgetting), this adds it to the default compiler flags so that it gets included in every source file we build. Change-Id: I53622ab4d46c55d942e98cae6ec03049fd5b3d08 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/87475 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Zachary Clark Reviewed-by: Roland Veloz Reviewed-by: Christian R Geddes Reviewed-by: Nicholas E Bofferding

Do nothing with error logs after shutdown event is received.

2019-10-15T21:00:48+00:00

Disable processing of error logs by the error log server after receiving the shutdown event. This is to prevent the possibility of bad things from happening once other services are shutdown. CQ: SW465848 Change-Id: I59c4951182d43a78f5704b4b4c3379f10dd03182 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85278 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: FSP CI Jenkins Tested-by: Jenkins OP HW Reviewed-by: Michael Baiocchi Reviewed-by: Roland Veloz Reviewed-by: Daniel M Crowell

Add OMI bus support to callouts

2019-10-10T13:07:00+00:00

Fill in a few spots where we need to handle OMI busses for proper error processing and display. Change-Id: Ibf236a7f6cb894d1516dbbe49b57e5be7dcceca2 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84952 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Corey V Swenson Reviewed-by: Matt Derksen Reviewed-by: Christian R Geddes Reviewed-by: William G Hoffa

errl: Free memory allocated for parsers

2019-10-03T17:32:37+00:00

Errl's factory creates new instance of User Defined Data parser on every call, but doesn't free it after usage. Resolves #184 Signed-off-by: Artem Senichev Change-Id: I8e8bd54e7aaa4ddb813cec3485404b6ba7a29ffa Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84518 Reviewed-by: Corey V Swenson Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Matt Derksen Reviewed-by: Daniel M Crowell

errl: Fix data reading from unaligned pointers

2019-10-03T17:32:06+00:00

Some architectures (like an ARM used in OpenBMC) do not support unaligned memory access. On these systems, reading an integral value from an unaligned pointer leads to undefined behavior. This patch doesn't change existing functionality, but forces the compiler to generate extra instructions to satisfy architectural alignment requirements. Resolves #185 Signed-off-by: Artem Senichev Change-Id: I6e75044b93c26cca76336d17bb3886fab403253a Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84520 Reviewed-by: Matt Derksen Reviewed-by: Christian R Geddes Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Daniel M Crowell

Compile Hostboot with -Os

2019-10-03T15:55:14+00:00

Hostboot currently spends a significant percentage of time loading data from PNOR across a relatively slow LPC bus. This commit enables compilation of Hostboot with -Os, optimized for space to reduce the amount of data required to be transferred across the LPC bus Rough measurements show a ~30% size reduction of the hostboot image and a ~10% reduction (improvement) in boot time Change-Id: Ib73863019595a24cc7d10e924bc5c92cd64af1ed Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84436 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: William G Hoffa

NVDIMM: FW_UPDATE: New FFDC for SECURITY_ERROR

2019-09-13T15:31:35+00:00

For any command error or timeout during FW_UPDATE add regs to error log. Registers specified in NVDIMM IPL Error Handling Document. CQ:SW473060 Change-Id: I3ca8933b9c62f0b12bebefbae06357400e8e436e Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83590 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Daniel M Crowell

Cache VERSION Partition

2019-08-29T21:34:42+00:00

This commit adds logic to cache the VERSION partition so that errl commit function is able to use the cached data instead of sending messages to SPnorRP queue. Said messages also cause deadlocks if secureboot verifications fail, since the code attempts to send a synch message to the SPnorRP queue while it's handling another synch message. These changes only impact OP systems and code paths. Change-Id: I9eeb05878d98fb2891fe76adc06ad376edc77fbe CQ: SW465038 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82304 Reviewed-by: Nicholas E Bofferding Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Glenn Miles Reviewed-by: Michael Baiocchi Reviewed-by: Daniel M Crowell

Add subsystem translations for NVDIMM part callouts

2019-08-22T13:32:00+00:00

A few new part callouts were added to support the NVDIMM function but a corresponding error log subsystem was never added. This change also adds a testcase to check for missing subsystems going forward. Change-Id: I523840615fe734553dd30af8e608c1aa214fd2dc Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82591 Tested-by: Jenkins Server Reviewed-by: Corey V Swenson Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Reviewed-by: Matt Derksen Tested-by: FSP CI Jenkins Reviewed-by: ARAVIND T. NAIR Reviewed-by: Daniel M Crowell