diff options
| author | Evan Lojewski <github@meklort.com> | 2020-07-11 14:30:46 -0600 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-07-11 14:30:46 -0600 |
| commit | 76db92af3f904b1c1d78b113510f2fb9f2eb6b29 (patch) | |
| tree | 65adf631f1e47121c7d80fdc4ce09a6113819879 /libs/NCSI | |
| parent | 2a370d432f5bb0580f9bfb5c24465f13c2726604 (diff) | |
| download | bcm5719-ortega-76db92af3f904b1c1d78b113510f2fb9f2eb6b29.tar.gz bcm5719-ortega-76db92af3f904b1c1d78b113510f2fb9f2eb6b29.zip | |
network: Fix a hang that can occur when the network drops during a transmission. (#86)
Diffstat (limited to 'libs/NCSI')
| -rw-r--r-- | libs/NCSI/ncsi.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/libs/NCSI/ncsi.c b/libs/NCSI/ncsi.c index 91197a4..55b7dbc 100644 --- a/libs/NCSI/ncsi.c +++ b/libs/NCSI/ncsi.c @@ -69,7 +69,7 @@ uint8_t gPackageID = ((0 << PACKAGE_ID_SHIFT) | CHANNEL_ID_PACKAGE); // Response frame - global and usable by one thread at a time only. -NetworkFrame_t gResponseFrame = +NetworkFrame_t gResponseFrame = { .responsePacket = { .DestinationAddress = {0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF}, @@ -717,8 +717,14 @@ void NCSI_TxPacket(uint32_t *packet, uint32_t packet_len) txControl.bits.LastByteCount = packet_len; /* 2 bits - automatically rounded. */ // Wait for enough free space. - while (APE_PERI.BmcToNcTxStatus.bits.InFifo < packetWords) + int max_loops = 0x10000; + while (APE_PERI.BmcToNcTxStatus.bits.InFifo < packetWords && --max_loops) + ; + + if (!max_loops) { + printf("Error waiting for fifo space. Dropping NCSI packet."); + return; } // Transmit. |
