//===--- InaccurateEraseCheck.cpp - clang-tidy-----------------------------===// // // The LLVM Compiler Infrastructure // // This file is distributed under the University of Illinois Open Source // License. See LICENSE.TXT for details. // //===----------------------------------------------------------------------===// #include "InaccurateEraseCheck.h" #include "clang/AST/ASTContext.h" #include "clang/ASTMatchers/ASTMatchFinder.h" #include "clang/Lex/Lexer.h" using namespace clang::ast_matchers; namespace clang { namespace tidy { namespace misc { void InaccurateEraseCheck::registerMatchers(MatchFinder *Finder) { const auto CheckForEndCall = hasArgument( 1, anyOf(constructExpr(has(memberCallExpr(callee(methodDecl(hasName("end")))) .bind("InaccEndCall"))), anything())); Finder->addMatcher( memberCallExpr( on(hasType(namedDecl(matchesName("^::std::")))), callee(methodDecl(hasName("erase"))), argumentCountIs(1), hasArgument(0, has(callExpr(callee(functionDecl(matchesName( "^::std::(remove(_if)?|unique)$"))), CheckForEndCall).bind("InaccAlgCall"))), unless(isInTemplateInstantiation())).bind("InaccErase"), this); } void InaccurateEraseCheck::check(const MatchFinder::MatchResult &Result) { const auto *MemberCall = Result.Nodes.getNodeAs("InaccErase"); const auto *EndExpr = Result.Nodes.getNodeAs("InaccEndCall"); const SourceLocation Loc = MemberCall->getLocStart(); FixItHint Hint; if (!Loc.isMacroID() && EndExpr) { const auto *AlgCall = Result.Nodes.getNodeAs("InaccAlgCall"); std::string ReplacementText = Lexer::getSourceText( CharSourceRange::getTokenRange(EndExpr->getSourceRange()), *Result.SourceManager, Result.Context->getLangOpts()); const SourceLocation EndLoc = Lexer::getLocForEndOfToken( AlgCall->getLocEnd(), 0, *Result.SourceManager, Result.Context->getLangOpts()); Hint = FixItHint::CreateInsertion(EndLoc, ", " + ReplacementText); } diag(Loc, "this call will remove at most one item even when multiple items " "should be removed") << Hint; } } // namespace misc } // namespace tidy } // namespace clang