From 56b3640b945c38c1a761a8811f30c04deabb5e67 Mon Sep 17 00:00:00 2001 From: Uday Bondhugula Date: Mon, 7 Jan 2019 15:06:32 -0800 Subject: Misc readability and doc / code comment related improvements - NFC - when SSAValue/MLValue existed, code at several places was forced to create additional aggregate temporaries of SmallVector to handle the conversion; get rid of such redundant code - use filling ctors instead of explicit loops - for smallvectors, change insert(list.end(), ...) -> append(... - improve comments at various places - turn getMemRefAccess into MemRefAccess ctor and drop duplicated getMemRefAccess. In the next CL, provide getAccess() accessors for load, store, DMA op's to return a MemRefAccess. PiperOrigin-RevId: 228243638 --- mlir/lib/Transforms/MemRefDataFlowOpt.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'mlir/lib/Transforms/MemRefDataFlowOpt.cpp') diff --git a/mlir/lib/Transforms/MemRefDataFlowOpt.cpp b/mlir/lib/Transforms/MemRefDataFlowOpt.cpp index 49b33b0596b..adf91b76276 100644 --- a/mlir/lib/Transforms/MemRefDataFlowOpt.cpp +++ b/mlir/lib/Transforms/MemRefDataFlowOpt.cpp @@ -128,9 +128,8 @@ void MemRefDataFlowOpt::visitOperationInst(OperationInst *opInst) { // post-dominance on these. 'fwdingCandidates' are a subset of depSrcStores. SmallVector depSrcStores; for (auto *storeOpInst : storeOps) { - MemRefAccess srcAccess, destAccess; - getMemRefAccess(storeOpInst, &srcAccess); - getMemRefAccess(loadOpInst, &destAccess); + MemRefAccess srcAccess(storeOpInst); + MemRefAccess destAccess(loadOpInst); FlatAffineConstraints dependenceConstraints; unsigned nsLoops = getNumCommonSurroundingLoops(*loadOpInst, *storeOpInst); // Dependences at loop depth <= minSurroundingLoops do NOT matter. -- cgit v1.2.3