From 4e41694538ca8b0ca825fed8ee9312fb15177e21 Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Tue, 19 Jan 2016 21:22:36 +0000 Subject: Fix undefined behavior in llvm's local changes to googletest. r100895 landed an llvm-only change to add minix support to googletest. It did that by putting "defined()" in a macro, which has undefined behavior. Slightly reshuffle things to remove that undefined behavior. Also mention in README.LLVM that minix support is a local change. llvm-svn: 258190 --- llvm/utils/unittest/googletest/include/gtest/internal/gtest-port.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'llvm/utils/unittest/googletest/include/gtest') diff --git a/llvm/utils/unittest/googletest/include/gtest/internal/gtest-port.h b/llvm/utils/unittest/googletest/include/gtest/internal/gtest-port.h index 6b942e9f9d9..cac04a7bb72 100644 --- a/llvm/utils/unittest/googletest/include/gtest/internal/gtest-port.h +++ b/llvm/utils/unittest/googletest/include/gtest/internal/gtest-port.h @@ -92,6 +92,7 @@ // GTEST_OS_LINUX - Linux // GTEST_OS_LINUX_ANDROID - Google Android // GTEST_OS_MAC - Mac OS X +// GTEST_OS_MINIX - Minix // GTEST_OS_NACL - Google Native Client (NaCl) // GTEST_OS_SOLARIS - Sun Solaris // GTEST_OS_SYMBIAN - Symbian @@ -248,6 +249,8 @@ # define GTEST_OS_NACL 1 #elif defined(__HAIKU__) # define GTEST_OS_HAIKU 1 +#elif defined(_MINIX) +# define GTEST_OS_MINIX 1 #endif // __CYGWIN__ // Brings in definitions for functions used in the testing::internal::posix @@ -359,7 +362,7 @@ // no support for it at least as recent as Froyo (2.2). // Minix currently doesn't support it either. # define GTEST_HAS_STD_WSTRING \ - (!(GTEST_OS_LINUX_ANDROID || GTEST_OS_CYGWIN || GTEST_OS_SOLARIS || GTEST_OS_HAIKU || defined(_MINIX))) + (!(GTEST_OS_LINUX_ANDROID || GTEST_OS_CYGWIN || GTEST_OS_SOLARIS || GTEST_OS_HAIKU || GTEST_OS_MINIX)) #endif // GTEST_HAS_STD_WSTRING -- cgit v1.2.3