From c95bd8d88f660d39ff7ffaed4a78b7f2622b5641 Mon Sep 17 00:00:00 2001 From: Filip Pizlo Date: Thu, 20 Feb 2014 23:57:31 +0000 Subject: Stackmaps are used for OSR exits, which is a custom kind of unwinding. Hence, they should not be marked nounwind. Marking them nounwind caused crashes in the WebKit FTL JIT, because if we enable sufficient optimizations, LLVM starts eliding compact_unwind sections (or any unwind data for that matter), making deoptimization via stackmaps impossible. This changes the stackmap intrinsic to be may-throw, adds a test for exactly the sympton that WebKit saw, and fixes TableGen to handle un-attributed intrinsics. Thanks to atrick and philipreames for reviewing this. llvm-svn: 201826 --- llvm/utils/TableGen/IntrinsicEmitter.cpp | 1 + 1 file changed, 1 insertion(+) (limited to 'llvm/utils/TableGen') diff --git a/llvm/utils/TableGen/IntrinsicEmitter.cpp b/llvm/utils/TableGen/IntrinsicEmitter.cpp index 173e5065327..d366861992d 100644 --- a/llvm/utils/TableGen/IntrinsicEmitter.cpp +++ b/llvm/utils/TableGen/IntrinsicEmitter.cpp @@ -666,6 +666,7 @@ EmitAttributes(const std::vector &Ints, raw_ostream &OS) { OS << " }\n"; } else { OS << " return AttributeSet();\n"; + OS << " }\n"; } } -- cgit v1.2.3