From adb6da10b81d35008178826adfc678275e776c9d Mon Sep 17 00:00:00 2001 From: Thomas Lively Date: Tue, 28 Aug 2018 18:49:47 +0000 Subject: [WebAssembly][NFC] Document stackifier tablegen backend Summary: Add comments to help readers avoid having to read tablegen backends to understand the code. Also remove unecessary breaks from the output. Reviewers: dschuff, aheejin Subscribers: sbc100, jgravelle-google, sunfish, llvm-commits Differential Revision: https://reviews.llvm.org/D51371 llvm-svn: 340864 --- llvm/utils/TableGen/WebAssemblyStackifierEmitter.cpp | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) (limited to 'llvm/utils/TableGen/WebAssemblyStackifierEmitter.cpp') diff --git a/llvm/utils/TableGen/WebAssemblyStackifierEmitter.cpp b/llvm/utils/TableGen/WebAssemblyStackifierEmitter.cpp index de637e5be57..0b9741d22b8 100644 --- a/llvm/utils/TableGen/WebAssemblyStackifierEmitter.cpp +++ b/llvm/utils/TableGen/WebAssemblyStackifierEmitter.cpp @@ -17,6 +17,17 @@ namespace llvm { +// Find all register WebAssembly instructions and their corresponding stack +// instructions. For each pair, emit a switch case of the form +// +// case WebAssembly::RegisterInstr: return WebAssembly::StackInstr; +// +// For example, +// +// case WebAssembly::ADD_I32: return WebAssembly::ADD_I32_S; +// +// This is useful for converting instructions from their register form to their +// equivalent stack form. void EmitWebAssemblyStackifier(RecordKeeper &RK, raw_ostream &OS) { Record *InstrClass = RK.getClass("WebAssemblyInst"); for (auto &RecordPair : RK.getDefs()) { @@ -26,7 +37,7 @@ void EmitWebAssemblyStackifier(RecordKeeper &RK, raw_ostream &OS) { if (IsStackBased) continue; OS << " case WebAssembly::" << RecordPair.first << ": return " - << "WebAssembly::" << RecordPair.first << "_S; break;\n"; + << "WebAssembly::" << RecordPair.first << "_S;\n"; } } -- cgit v1.2.3