From eaa3d2a63c8f509e07aa6c8fa80c28e01fba47f8 Mon Sep 17 00:00:00 2001 From: Teresa Johnson Date: Wed, 30 Sep 2015 13:20:37 +0000 Subject: Add support for sub-byte aligned writes to lib/Support/Endian.h Summary: As per Duncan's review for D12536, I extracted the sub-byte bit aligned reading and writing code into lib/Support, and generalized it. Added calls from BackpatchWord. Also added unittests. Reviewers: dexonsmith Subscribers: llvm-commits Differential Revision: http://reviews.llvm.org/D13189 llvm-svn: 248897 --- llvm/unittests/Support/EndianTest.cpp | 48 +++++++++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+) (limited to 'llvm/unittests/Support') diff --git a/llvm/unittests/Support/EndianTest.cpp b/llvm/unittests/Support/EndianTest.cpp index 8f935530638..ee236d0eec9 100644 --- a/llvm/unittests/Support/EndianTest.cpp +++ b/llvm/unittests/Support/EndianTest.cpp @@ -32,6 +32,54 @@ TEST(Endian, Read) { (endian::read(littleval + 1))); } +TEST(Endian, ReadBitAligned) { + // Simple test to make sure we properly pull out the 0x0 word. + unsigned char littleval[] = {0x3f, 0x00, 0x00, 0x00, 0xc0, 0xff, 0xff, 0xff}; + unsigned char bigval[] = {0x00, 0x00, 0x00, 0x3f, 0xff, 0xff, 0xff, 0xc0}; + EXPECT_EQ( + (endian::readAtBitAlignment(&littleval[0], 6)), + 0x0); + EXPECT_EQ((endian::readAtBitAlignment(&bigval[0], 6)), + 0x0); + // Test to make sure that signed right shift of 0xf0000000 is masked + // properly. + unsigned char littleval2[] = {0x00, 0x00, 0x00, 0xf0, 0x00, 0x00, 0x00, 0x00}; + unsigned char bigval2[] = {0xf0, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}; + EXPECT_EQ( + (endian::readAtBitAlignment(&littleval2[0], 4)), + 0x0f000000); + EXPECT_EQ((endian::readAtBitAlignment(&bigval2[0], 4)), + 0x0f000000); +} + +TEST(Endian, WriteBitAligned) { + // This test ensures that signed right shift of 0xffffaa is masked + // properly. + unsigned char bigval[8] = {0x00}; + endian::writeAtBitAlignment(bigval, (int)0xffffaaaa, + 4); + EXPECT_EQ(bigval[0], 0xff); + EXPECT_EQ(bigval[1], 0xfa); + EXPECT_EQ(bigval[2], 0xaa); + EXPECT_EQ(bigval[3], 0xa0); + EXPECT_EQ(bigval[4], 0x00); + EXPECT_EQ(bigval[5], 0x00); + EXPECT_EQ(bigval[6], 0x00); + EXPECT_EQ(bigval[7], 0x0f); + + unsigned char littleval[8] = {0x00}; + endian::writeAtBitAlignment(littleval, + (int)0xffffaaaa, 4); + EXPECT_EQ(littleval[0], 0xa0); + EXPECT_EQ(littleval[1], 0xaa); + EXPECT_EQ(littleval[2], 0xfa); + EXPECT_EQ(littleval[3], 0xff); + EXPECT_EQ(littleval[4], 0x0f); + EXPECT_EQ(littleval[5], 0x00); + EXPECT_EQ(littleval[6], 0x00); + EXPECT_EQ(littleval[7], 0x00); +} + TEST(Endian, Write) { unsigned char data[5]; endian::write(data, -1362446643); -- cgit v1.2.3