From a6fe345ac9613215237fa3fcbae4e34119d4ecf0 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 11 Jun 2019 16:42:42 +0000 Subject: [Path] Set FD to -1 in moved-from TempFile When moving a temp file, explicitly set the file descriptor to -1 so we can never accidentally close the moved-from TempFile. Differential revision: https://reviews.llvm.org/D63087 llvm-svn: 363083 --- llvm/unittests/Support/Path.cpp | 2 ++ 1 file changed, 2 insertions(+) (limited to 'llvm/unittests/Support') diff --git a/llvm/unittests/Support/Path.cpp b/llvm/unittests/Support/Path.cpp index 4eee8e923b7..f0e11b4e3f6 100644 --- a/llvm/unittests/Support/Path.cpp +++ b/llvm/unittests/Support/Path.cpp @@ -578,6 +578,7 @@ TEST_F(FileSystemTest, TempFileKeepDiscard) { auto TempFileOrError = fs::TempFile::create(TestDirectory + "/test-%%%%"); ASSERT_TRUE((bool)TempFileOrError); fs::TempFile File = std::move(*TempFileOrError); + ASSERT_EQ(-1, TempFileOrError->FD); ASSERT_FALSE((bool)File.keep(TestDirectory + "/keep")); ASSERT_FALSE((bool)File.discard()); ASSERT_TRUE(fs::exists(TestDirectory + "/keep")); @@ -589,6 +590,7 @@ TEST_F(FileSystemTest, TempFileDiscardDiscard) { auto TempFileOrError = fs::TempFile::create(TestDirectory + "/test-%%%%"); ASSERT_TRUE((bool)TempFileOrError); fs::TempFile File = std::move(*TempFileOrError); + ASSERT_EQ(-1, TempFileOrError->FD); ASSERT_FALSE((bool)File.discard()); ASSERT_FALSE((bool)File.discard()); ASSERT_FALSE(fs::exists(TestDirectory + "/keep")); -- cgit v1.2.3