From 46c561c19e5b9d8bb77f7b98f0803b4c386243e4 Mon Sep 17 00:00:00 2001 From: David Blaikie Date: Mon, 11 May 2015 22:20:48 +0000 Subject: Readdress r236990, use of static members on a non-static variable. The TargetRegistry is just a namespace-like class, instantiated in one place to use a range-based for loop. Instead, expose access to the registry via a range-based 'targets()' function instead. This makes most uses a bit awkward/more verbose - but eventually we should just add a range-based find_if function which will streamline these functions. I'm happy to mkae them a bit awkward in the interim as encouragement to improve the algorithms in time. llvm-svn: 237059 --- llvm/unittests/Support/TargetRegistry.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'llvm/unittests/Support') diff --git a/llvm/unittests/Support/TargetRegistry.cpp b/llvm/unittests/Support/TargetRegistry.cpp index 2dd57fa7bf1..ae89c8b6493 100644 --- a/llvm/unittests/Support/TargetRegistry.cpp +++ b/llvm/unittests/Support/TargetRegistry.cpp @@ -22,9 +22,8 @@ TEST(TargetRegistry, TargetHasArchType) { llvm::InitializeAllTargetInfos(); - for (auto I = TargetRegistry::begin(), E = TargetRegistry::end(); - I != E; ++I) { - StringRef Name = I->getName(); + for (const Target &T : TargetRegistry::targets()) { + StringRef Name = T.getName(); // There is really no way (at present) to ask a Target whether it targets // a specific architecture, because the logic for that is buried in a // predicate. -- cgit v1.2.3