From f5f35c5cd110e22c4b216ec1dc53255e32adc011 Mon Sep 17 00:00:00 2001 From: Igor Kudrin Date: Tue, 6 Aug 2019 10:47:20 +0000 Subject: Support 64-bit offsets in utility classes (1/5) Using 64-bit offsets is required to fully implement 64-bit DWARF. As these classes are used in many different libraries they should temporarily support both 32- and 64-bit offsets. Differential Revision: https://reviews.llvm.org/D64006 llvm-svn: 368013 --- llvm/unittests/Support/DataExtractorTest.cpp | 30 ++++++++++++++++++---------- 1 file changed, 19 insertions(+), 11 deletions(-) (limited to 'llvm/unittests/Support/DataExtractorTest.cpp') diff --git a/llvm/unittests/Support/DataExtractorTest.cpp b/llvm/unittests/Support/DataExtractorTest.cpp index 9726a74d81f..391b27178d6 100644 --- a/llvm/unittests/Support/DataExtractorTest.cpp +++ b/llvm/unittests/Support/DataExtractorTest.cpp @@ -12,19 +12,27 @@ using namespace llvm; namespace { +// Test fixture +template +class DataExtractorTest : public ::testing::Test { }; + +// Test DataExtractor with both types which can be used for offsets. +typedef ::testing::Types TestTypes; +TYPED_TEST_CASE(DataExtractorTest, TestTypes); + const char numberData[] = "\x80\x90\xFF\xFF\x80\x00\x00\x00"; const char stringData[] = "hellohello\0hello"; const char leb128data[] = "\xA6\x49"; const char bigleb128data[] = "\xAA\xA9\xFF\xAA\xFF\xAA\xFF\x4A"; -TEST(DataExtractorTest, OffsetOverflow) { +TYPED_TEST(DataExtractorTest, OffsetOverflow) { DataExtractor DE(StringRef(numberData, sizeof(numberData)-1), false, 8); EXPECT_FALSE(DE.isValidOffsetForDataOfSize(-2U, 5)); } -TEST(DataExtractorTest, UnsignedNumbers) { +TYPED_TEST(DataExtractorTest, UnsignedNumbers) { DataExtractor DE(StringRef(numberData, sizeof(numberData)-1), false, 8); - uint32_t offset = 0; + TypeParam offset = 0; EXPECT_EQ(0x80U, DE.getU8(&offset)); EXPECT_EQ(1U, offset); @@ -70,9 +78,9 @@ TEST(DataExtractorTest, UnsignedNumbers) { EXPECT_EQ(8U, offset); } -TEST(DataExtractorTest, SignedNumbers) { +TYPED_TEST(DataExtractorTest, SignedNumbers) { DataExtractor DE(StringRef(numberData, sizeof(numberData)-1), false, 8); - uint32_t offset = 0; + TypeParam offset = 0; EXPECT_EQ(-128, DE.getSigned(&offset, 1)); EXPECT_EQ(1U, offset); @@ -87,9 +95,9 @@ TEST(DataExtractorTest, SignedNumbers) { EXPECT_EQ(8U, offset); } -TEST(DataExtractorTest, Strings) { +TYPED_TEST(DataExtractorTest, Strings) { DataExtractor DE(StringRef(stringData, sizeof(stringData)-1), false, 8); - uint32_t offset = 0; + TypeParam offset = 0; EXPECT_EQ(stringData, DE.getCStr(&offset)); EXPECT_EQ(11U, offset); @@ -97,9 +105,9 @@ TEST(DataExtractorTest, Strings) { EXPECT_EQ(11U, offset); } -TEST(DataExtractorTest, LEB128) { +TYPED_TEST(DataExtractorTest, LEB128) { DataExtractor DE(StringRef(leb128data, sizeof(leb128data)-1), false, 8); - uint32_t offset = 0; + TypeParam offset = 0; EXPECT_EQ(9382ULL, DE.getULEB128(&offset)); EXPECT_EQ(2U, offset); @@ -116,9 +124,9 @@ TEST(DataExtractorTest, LEB128) { EXPECT_EQ(8U, offset); } -TEST(DataExtractorTest, LEB128_error) { +TYPED_TEST(DataExtractorTest, LEB128_error) { DataExtractor DE(StringRef("\x81"), false, 8); - uint32_t Offset = 0; + TypeParam Offset = 0; EXPECT_EQ(0U, DE.getULEB128(&Offset)); EXPECT_EQ(0U, Offset); -- cgit v1.2.3