From e995ce5498fe255b2a9f69dceb39044de4e8651f Mon Sep 17 00:00:00 2001 From: Simon Pilgrim Date: Tue, 9 Jul 2019 12:20:04 +0000 Subject: [ADT] Enable ArrayRef/StringRef is_assignable tests on MSVC Now that we've dropped VS2015 support (D64326) we can enable these static_asserts on MSVC builds as VS2017+ correctly handles them llvm-svn: 365471 --- llvm/unittests/ADT/StringRefTest.cpp | 6 ------ 1 file changed, 6 deletions(-) (limited to 'llvm/unittests/ADT/StringRefTest.cpp') diff --git a/llvm/unittests/ADT/StringRefTest.cpp b/llvm/unittests/ADT/StringRefTest.cpp index 6f83dc3224a..a45e83c1163 100644 --- a/llvm/unittests/ADT/StringRefTest.cpp +++ b/llvm/unittests/ADT/StringRefTest.cpp @@ -34,10 +34,6 @@ std::ostream &operator<<(std::ostream &OS, // Check that we can't accidentally assign a temporary std::string to a // StringRef. (Unfortunately we can't make use of the same thing with // constructors.) -// -// Disable this check under MSVC; even MSVC 2015 isn't consistent between -// std::is_assignable and actually writing such an assignment. -#if !defined(_MSC_VER) static_assert( !std::is_assignable::value, "Assigning from prvalue std::string"); @@ -56,8 +52,6 @@ static_assert( static_assert( std::is_assignable::value, "Assigning from lvalue C string"); -#endif - namespace { TEST(StringRefTest, Construction) { -- cgit v1.2.3