From f10a871419c3bfb05690add75201b1cb56c8e96d Mon Sep 17 00:00:00 2001 From: Saleem Abdulrasool Date: Mon, 14 Nov 2016 21:10:41 +0000 Subject: Revert "Revert "llvm-strings: support printing the filename"" Change the dynamic files to static in the hope that it will actually fix the transient errors that Ive been unable to reproduce. llvm-svn: 286891 --- llvm/tools/llvm-strings/llvm-strings.cpp | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) (limited to 'llvm/tools/llvm-strings') diff --git a/llvm/tools/llvm-strings/llvm-strings.cpp b/llvm/tools/llvm-strings/llvm-strings.cpp index 6e5e2f298c3..cb0fb9651d9 100644 --- a/llvm/tools/llvm-strings/llvm-strings.cpp +++ b/llvm/tools/llvm-strings/llvm-strings.cpp @@ -29,7 +29,19 @@ static cl::list InputFileNames(cl::Positional, cl::desc(""), cl::ZeroOrMore); -static void strings(raw_ostream &OS, StringRef Contents) { +static cl::opt + PrintFileName("print-file-name", + cl::desc("Print the name of the file before each string")); +static cl::alias PrintFileNameShort("f", cl::desc(""), + cl::aliasopt(PrintFileName)); + +static void strings(raw_ostream &OS, StringRef FileName, StringRef Contents) { + auto print = [&OS, FileName](StringRef L) { + if (PrintFileName) + OS << FileName << ": "; + OS << L << '\n'; + }; + const char *P = nullptr, *E = nullptr, *S = nullptr; for (P = Contents.begin(), E = Contents.end(); P < E; ++P) { if (std::isgraph(*P) || std::isblank(*P)) { @@ -37,12 +49,12 @@ static void strings(raw_ostream &OS, StringRef Contents) { S = P; } else if (S) { if (P - S > 3) - OS << StringRef(S, P - S) << '\n'; + print(StringRef(S, P - S)); S = nullptr; } } if (S && E - S > 3) - OS << StringRef(S, E - S) << '\n'; + print(StringRef(S, E - S)); } int main(int argc, char **argv) { @@ -60,7 +72,8 @@ int main(int argc, char **argv) { if (std::error_code EC = Buffer.getError()) errs() << File << ": " << EC.message() << '\n'; else - strings(llvm::outs(), Buffer.get()->getMemBufferRef().getBuffer()); + strings(llvm::outs(), File == "-" ? "{standard input}" : File, + Buffer.get()->getMemBufferRef().getBuffer()); } return EXIT_SUCCESS; -- cgit v1.2.3