From be8b0ea8542a652207c46fdf9ed412729d248c83 Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Tue, 7 Jul 2015 17:12:59 +0000 Subject: Delete UnknownAddress. It is a perfectly valid symbol value. getSymbolValue now returns a value that in convenient for most callers: * 0 for undefined * symbol size for common symbols * offset/address for symbols the rest Code that needs something more specific can check getSymbolFlags. llvm-svn: 241605 --- llvm/tools/llvm-objdump/llvm-objdump.cpp | 7 ------- 1 file changed, 7 deletions(-) (limited to 'llvm/tools/llvm-objdump/llvm-objdump.cpp') diff --git a/llvm/tools/llvm-objdump/llvm-objdump.cpp b/llvm/tools/llvm-objdump/llvm-objdump.cpp index 81deefe651d..0cb4fc24aa4 100644 --- a/llvm/tools/llvm-objdump/llvm-objdump.cpp +++ b/llvm/tools/llvm-objdump/llvm-objdump.cpp @@ -825,8 +825,6 @@ static void DisassembleObject(const ObjectFile *Obj, bool InlineRelocs) { if (error(AddressOrErr.getError())) break; uint64_t Address = *AddressOrErr; - if (Address == UnknownAddress) - continue; Address -= SectionAddr; if (Address >= SectSize) continue; @@ -1136,11 +1134,6 @@ void llvm::PrintSymbolTable(const ObjectFile *o) { bool Common = Flags & SymbolRef::SF_Common; bool Hidden = Flags & SymbolRef::SF_Hidden; - if (Common) - Address = Symbol.getCommonSize(); - - if (Address == UnknownAddress) - Address = 0; char GlobLoc = ' '; if (Type != SymbolRef::ST_Unknown) GlobLoc = Global ? 'g' : 'l'; -- cgit v1.2.3