From a5a4ff5a5821fb55afc8f39194f8d6da039a872f Mon Sep 17 00:00:00 2001 From: Eli Bendersky Date: Fri, 25 Jan 2013 20:53:41 +0000 Subject: When encountering an unknown file format, ObjectFile::createObjectFile should politely report it instead of running into llvm_unreachable. Also patch llvm-dwarfdump to actually check whether the file it's attempting to dump is a valid object file. llvm-svn: 173489 --- llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp') diff --git a/llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp b/llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp index 06875005837..6041510e039 100644 --- a/llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp +++ b/llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp @@ -86,6 +86,11 @@ static void DumpInput(const StringRef &Filename) { } OwningPtr Obj(ObjectFile::createObjectFile(Buff.take())); + if (!Obj) { + errs() << Filename << ": Unknown object file format\n"; + return; + } + OwningPtr DICtx(DIContext::getDWARFContext(Obj.get())); if (Address == -1ULL) { -- cgit v1.2.3